fix: rename credentialId to clusterId in ClustersClient methods#575
Open
Jah-yee wants to merge 1 commit intomicrosoft:nextfrom
Open
fix: rename credentialId to clusterId in ClustersClient methods#575Jah-yee wants to merge 1 commit intomicrosoft:nextfrom
Jah-yee wants to merge 1 commit intomicrosoft:nextfrom
Conversation
Rename parameter from credentialId to clusterId in exists() and deleteClient() methods to align with the Cluster ID Architecture and improve code clarity. Good day, This PR addresses issue microsoft#567 by renaming the parameter from credentialId to clusterId in the exists() and deleteClient() methods of ClustersClient.ts. This is a purely cosmetic rename with no functional impact but improves code clarity and alignment with: - The Cluster ID Architecture documented in copilot-instructions.md - Other ClustersClient methods: getClient(clusterId), getExistingClient(clusterId) - All methods in CredentialCache.ts which consistently use clusterId Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust. Warmly, RoomWithOutRoof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR addresses issue #567 by renaming the parameter from
credentialIdtoclusterIdin theexists()anddeleteClient()methods ofClustersClient.ts.This is a purely cosmetic rename with no functional impact but improves code clarity and alignment with:
getClient(clusterId),getExistingClient(clusterId)CredentialCache.tswhich consistently useclusterIdThe inconsistency appears to be a naming oversight — functionally, both parameters are used as keys into the same
_clientsMap which is keyed by clusterId.Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof