Conversation
… development Adds GitHub Copilot automation for ScriptDOM development: add-feature skill with platform detection (SQL Server/Azure/Fabric/VNext), database option implementation guide with 4 patterns, and agent integration. Enables developers to use Copilot for guided T-SQL feature implementation. Related ADO wiki: [Adding or Extending TSql support](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838) - [x] The [Common checklist](https://msdata.visualstudio.com/SQLToolsAndLibraries/_git/Common?path=/Templates/PR%20Checklist%20for%20SQLToolsAndLibraries.md&version=GBmain&_a=preview) has been reviewed and followed - [x] Code changes are accompanied by appropriate unit tests (N/A - documentation only) - [x] Identified and included SMEs needed to review code changes - [x] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=make-the-changes-in) here to make changes in the code (N/A - documentation only) - [x] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=to-extend-the-tests-do-the-following%3A) here to add new tests (N/A - documentation only) - [x] Update relevant documentation in the [wiki](https://dev.azure.com/msdata/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki) and the README.md file Documentation changes only - no code or test impact. Files added: add-feature SKILL.md (282 lines), database_option.guidelines.instructions.md (493 lines). Files updated: parser.agent.md, copilot-instructions.md. ---- This pull request adds new documentation and workflow enhancements for ScriptDOM feature development. The changes introduce comprehensive guidance to help developers add new T-SQL features, with an emphasis on supporting database options in ScriptDOM. - `/.github/instructions/database_option.guidelines.instructions.md`: Added a detailed guide outlining multiple patterns for implementing database options. - `/.github/skills/add-feature/SKILL.md`: Introduced a new skill file to facilitate the feature addition workflow across various SQL platforms. - `/.github/agents/parser.agent.md`: Updated the parser agent workflow to incorporate the add-feature skill and direct users to the appropriate instructions. - `/.github/copilot-instructions.md`: Modified the Copilot instructions to reference the new database option guidelines. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
This PR: merges vbump 180 changes from rel/180 branch to main. Also have created rel/170.168 for future 170 releases. - [ ] The [Common checklist](https://msdata.visualstudio.com/SQLToolsAndLibraries/_git/Common?path=/Templates/PR%20Checklist%20for%20SQLToolsAndLibraries.md&version=GBmain&_a=preview) has been reviewed and followed - [ ] Code changes are accompanied by appropriate unit tests - [ ] Identified and included SMEs needed to review code changes - [ ] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=make-the-changes-in) here to make changes in the code - [ ] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=to-extend-the-tests-do-the-following%3A) here to add new tests for your feature - [ ] Update relevant documentation in the [wiki](https://dev.azure.com/msdata/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki) and the README.md file Please provide any additional information that might be helpful for the reviewers ---- This pull request adds new parser support and related tooling for SQL Server Yellowstone (vnext) by introducing the TSql180 parser version. This update implements full support for TSql180 with new parser components, script generation, test updates, and documentation for adding new parser versions. It also bumps relevant build and configuration files for the new version. The key changes include: - `/.github/instructions/adding_new_parser.guidelines.instructions.md`: Added comprehensive guidelines for adding new parser versions. - `/SqlScriptDom/Parser/TSql/TSql180Parser.cs` and `/SqlScriptDom/Parser/TSql/TSql180ParserBaseInternal.cs`: Introduced the new parser and its base internal class for SQL 180. - `/SqlScriptDom/ScriptDom/SqlServer/Sql180ScriptGenerator.cs` and `/SqlScriptDom/ScriptDom/SqlServer/ScriptGenerator/Sql180ScriptGeneratorVisitor.cs`: Implemented a new script generator and visitor for TSql180. - Test files (e.g., `/Test/SqlDom/Only180SyntaxTests.cs`) and test utilities have been updated to support version 180. - Build configuration files and versioning definitions (e.g., `SqlVersionFlags`, `/AssemblyInfo.props`, and `/GenerateFiles.props`) have been updated to reflect the new version. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #4792111, #4819213, #4826760, #4843961, #4844065, #4924682, #4932633, #4996528, #5003355
…ION database option support for... # Pull Request Template for ScriptDom ## Description The changes enable parsing and SQL generation for the new AUTOMATIC_INDEX_COMPACTION option by updating the relevant grammar, AST definitions, script generator logic, and tests. - `SqlScriptDom/ScriptDom/SqlServer/ScriptGenerator/SqlScriptGeneratorVisitor.AutomaticIndexCompactionDatabaseOption.cs`: Added a new visitor class to generate the SQL script for the option. - `SqlScriptDom/Parser/TSql/TSql180.g`: Introduced a new grammar rule for automaticIndexCompactionOption. - `SqlScriptDom/Parser/TSql/DatabaseOptionKind.cs`: Updated to include a new enum value for AUTOMATIC_INDEX_COMPACTION. - `SqlScriptDom/Parser/TSql/Ast.xml`: Added a new AST class for the AUTOMATIC_INDEX_COMPACTION option. - Test files (`Test/SqlDom/TestScripts/AutomaticIndexCompactionTests180.sql` and baseline updates): Added tests to validate the new option's syntax. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> ## Code Change - [ ] The [Common checklist](https://msdata.visualstudio.com/SQLToolsAndLibraries/_git/Common?path=/Templates/PR%20Checklist%20for%20SQLToolsAndLibraries.md&version=GBmain&_a=preview) has been reviewed and followed - [ ] Code changes are accompanied by appropriate unit tests - [ ] Identified and included SMEs needed to review code changes - [ ] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=make-the-changes-in) here to make changes in the code ## Testing - [ ] Follow the [steps](https://msdata.visualstudio.com/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki/33838/Adding-or-Extending-TSql-support-in-Sql-Dom?anchor=to-extend-the-tests-do-the-following%3A) here to add new tests for your feature ## Documentation - [ ] Update relevant documentation in the [wiki](https://dev.azure.com/msdata/SQLToolsAndLibraries/_wiki/wikis/SQLToolsAndLibraries.wiki) and the README.md file ## Additional Information Please provide any additional information that might be helpful for the reviewers Merged PR 2007778: Add AUTOMATIC_INDEX_COMPACTION database option support for TSql180 # Pull Request Template for ScriptDom ### Description Add support for the AUTOMATIC_INDEX_COMPACTION (AIC) database option to the ScriptDOM parser. AIC is an Azure SQL / versionless MI feature that is not tied to any particular compatibility level. This PR adds the grammar, AST, script generator, and tests for parsing ALTER DATABASE ... SET AUTOMATIC_INDEX_COMPACTION = ON/OFF. The grammar is added to TSql180 only (not TSql170 or TSqlFabricDW), per reviewer feedback. ### Changes - AST (Ast.xml): Added AutomaticIndexCompactionDatabaseOption node - Grammar (TSql180.g): Added automaticIndexCompactionOption rule and dispatch entry - Constants (CodeGenerationSupporter.cs): Added AutomaticIndexCompaction string constant - Enum (DatabaseOptionKind.cs): Added AutomaticIndexCompac...
Adding release notes for 180.6.0 ---- #### AI description (iteration 1) #### PR Classification Documentation update to add release notes for version 180.6.0 of Microsoft.SqlServer.TransactSql.ScriptDom. #### PR Summary This PR adds release notes documenting version 180.6.0, which includes a new 180 parser and maintains support for .NET Framework 4.7.2, .NET 8, and .NET Standard 2.0+ across multiple platforms. - `/release-notes/180/180.6.0.md`: New release notes file documenting target platform support (.NET Framework 4.7.2, .NET 8, .NET Standard 2.0+) and mentioning a new 180 parser feature <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
llali
requested review from
chlafreniere,
dzsquared,
kburtram and
ssreerama
as code owners
ssreerama
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync repos: commits for release 180.6.0