Update Kubernetes dependencies to v1.36.0-rc.0#9484
Open
mtrqq wants to merge 15 commits intokubernetes:masterfrom
Open
Update Kubernetes dependencies to v1.36.0-rc.0#9484mtrqq wants to merge 15 commits intokubernetes:masterfrom
mtrqq wants to merge 15 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/cluster-autoscaler
size/XXL
mtrqq
force-pushed
the
kubernetes-1.36-bump
branch
from
84675a7 to
b8f737c
Compare
mtrqq
force-pushed
the
kubernetes-1.36-bump
branch
from
b8f737c to
c40c25e
Compare
…e requirements Current version raises compilation errors with 1.36 tools/cache library version, this change bumps controller runtime to have it adapted to the new requirements. Example error: vendor/sigs.k8s.io/controller-runtime/pkg/cache/multi_namespace_cache.go:363:9: cannot use handles (variable of struct type handlerRegistration) as "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration value in return statement: handlerRegistration does not implement "k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration (missing method HasSyncedChecker) There's no release tag containing a PR with a fix, this patch uses a specific commit hash to depend on, which should later be replaced with a correct, non-pseudo version
… in scheduler plugin
This change also changes the assumptions in couple tests as node declared features graduated to beta in 1.36 enabling intergration by default
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mtrqq The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/assign BigDarkClown |
Contributor
|
/test pull-cluster-autoscaler-e2e-azure-master |
Contributor
|
/retest |
Contributor
Contributor
Author
@jackfrancis, that's correct, thanks for adding this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR updates dependencies to use kubernetes 1.36.0-rc.0 release tag
As part of this change I needed to patch multiple modules and tests to adapt to new APIs or feature gate getting enabled by default. Changes which affected that:
There's a new method on the scheduler SharedLister requiring us to implement PodGroupStates() method and interface on the delegating lister as well as the snapshots. Implementation added in this PR is no-op
There's a new method on the SharedDRAManager interface in scheduler requiring us to implement PodGroupLister interface inside DRA snapshot, predicate snapshot and delegate lister. Implementation added in this PR is no-op
New implementation of the node declared features works based on the bitsets where features need to be predefined for this to work, for some tests which rely on the default feature registry we needed to replace feature names with real ones instead of imaginary ones. Other tests needed to be patched as they are modifying a global framework object and it was done too late during the flow
There was a race condition in scheduler code which is never run for CA implementation, interface changes were required to ResourceClaimTracker interface
There's a change in
k8s.io/client-go/tools/cachepackage requiring to implement HasSyncedChecker, there's no release tag in controller-runtime dependency which can accommodate that, while the fix is already merged on 11th of March (kubernetes-sigs/controller-runtime#3462), currently pinned dependency is using pseudo version based on the commit hash*** Feature Gate Changes
DRAExtendedResourceis enabled by default since 1.36 which caused a test-level breakage (panic in scheduler plugin) as DRA shared manager is not initialized when DRA is disabled, the fix is to implement no-op shared DRA manager and to configure that for the scheduler frameworkNodeDeclaredFeaturesis enabled by default since 1.36 which required inverting an expectation when comparing sanitized node infos in testsWhich issue(s) this PR fixes:
Fixes #9382
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: