Fix duplicate "is" wording in jest-config displayName validation test#16046
Draft
Bojun-Vvibe wants to merge 1 commit intojestjs:mainfrom
Draft
Fix duplicate "is" wording in jest-config displayName validation test#16046Bojun-Vvibe wants to merge 1 commit intojestjs:mainfrom
Bojun-Vvibe wants to merge 1 commit intojestjs:mainfrom
Conversation
|
|
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo: jestjs/jest (⭐ 44000)
Type: test
Files changed: 3
Lines: +6/-2
What
The
displayNamevalidation test inpackages/jest-config/src/__tests__/normalize.test.tsuses atest.eachtemplate that interpolates adescriptioninto the title viadisplayName is $description. One row supplied'is an empty object'as the description, producing the titledisplayName is is an empty object(and a snapshot key with the same duplicated word). This change drops the redundantisfrom the row so the rendered test name reads naturally, and updates the matching snapshot key innormalize.test.ts.snap. A short CHANGELOG entry under## mainis included.Why
Pure readability/quality improvement. The duplicated word shows up in test runner output and in the committed snapshot file, where it looks like a typo. The other rows in the same
test.eachtable ('missing color','missing name','using invalid values') all read correctly when prefixed withis, so the empty-object row is the inconsistent one. Fix is mechanical and risk-free.Testing
yarn jest packages/jest-config/src/__tests__/normalize.test.tswould re-run the affected describe block. The snapshot key was updated in lockstep with the new test title so the snapshot still matches; the actual snapshot body is unchanged. Did not run the suite locally (would requireyarn install+yarn build:js, outside the time budget).Risk
Low — only touches a test description string, the corresponding snapshot key, and a changelog line. No runtime/library code touched.