docs: add SAN extension to secure ingress certificate generation commands#17335
Open
Ahmedaltu wants to merge 2 commits intoistio:masterfrom
Open
docs: add SAN extension to secure ingress certificate generation commands#17335Ahmedaltu wants to merge 2 commits intoistio:masterfrom
Ahmedaltu wants to merge 2 commits intoistio:masterfrom
Conversation
Contributor
|
Hi @Ahmedaltu. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11675
What this PR does
Adds the
-extfileflag with a Subject Alternative Name (SAN) extensionto all
openssl x509certificate signing commands in the secure ingressdocumentation, and adds a note explaining the browser compatibility requirement.
Why
Since Chrome 58, browsers require certificates to have the domain name in
the Subject Alternative Name (SAN) extension, not just the Common Name (CN)
field. The current commands generate certificates without a SAN, which causes:
ERR_CERT_COMMON_NAME_INVALIDin ChromeSubject Alternative Name MissingerrorThis issue has been open since August 2022 (#11675).
Changes
Added
-extfile <(printf "subjectAltName=DNS:<domain>")to 4 certificatesigning commands:
Added a tip note explaining that the certificates are for testing only,
require SAN for modern browsers, and will not be automatically trusted.
Type of change