Clarify ResourceQuota from helm#17118
Conversation
|
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @tomasmota. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| #### Platform profile | ||
|
|
||
| When using GKE you must append the correct `platform` value to your installation commands, as GKE uses nonstandard locations for CNI binaries which requires Helm overrides. | ||
| When using GKE you must append the correct `platform` value to your installation commands, as GKE uses nonstandard locations for CNI binaries which requires Helm overrides. This will also automatically add the necessary ResourceQuota mentioned above. |
There was a problem hiding this comment.
Small suggestion: the sentence here feels a bit late because the ResourceQuota is introduced earlier in the “Namespace restrictions” section. To avoid confusion (and potential duplicate ResourceQuota creation), could you move a short note immediately after the ResourceQuota YAML example that says Helm can create that ResourceQuota?
Suggested wording to insert right after the YAML example:
Note: Installing the istio-cni Helm chart with
--set global.platform=gke(see the Helm example below) will automatically create the ResourceQuota shown above.
If you add that there, please remove the duplicate sentence from the “Platform profile” here (or replace it with a short cross-reference like “(See note above about ResourceQuota creation.)”).
Description
It's not immediately clear from the values that setting the platform will create the resourcequota. Maybe this will save someone else trying to deploy duplicate resourcequotas like happened to me.
Reviewers