Skip to content

Clarify ResourceQuota from helm#17118

Open
tomasmota wants to merge 1 commit intoistio:release-1.28from
tomasmota:patch-1
Open

Clarify ResourceQuota from helm#17118
tomasmota wants to merge 1 commit intoistio:release-1.28from
tomasmota:patch-1

Conversation

@tomasmota
Copy link
Copy Markdown

Description

It's not immediately clear from the values that setting the platform will create the resourcequota. Maybe this will save someone else trying to deploy duplicate resourcequotas like happened to me.

Reviewers

  • [ x] Docs

@tomasmota tomasmota requested a review from a team as a code owner January 30, 2026 11:35
@istio-policy-bot
Copy link
Copy Markdown

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jan 30, 2026
@istio-testing
Copy link
Copy Markdown
Contributor

Hi @tomasmota. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

#### Platform profile

When using GKE you must append the correct `platform` value to your installation commands, as GKE uses nonstandard locations for CNI binaries which requires Helm overrides.
When using GKE you must append the correct `platform` value to your installation commands, as GKE uses nonstandard locations for CNI binaries which requires Helm overrides. This will also automatically add the necessary ResourceQuota mentioned above.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion: the sentence here feels a bit late because the ResourceQuota is introduced earlier in the “Namespace restrictions” section. To avoid confusion (and potential duplicate ResourceQuota creation), could you move a short note immediately after the ResourceQuota YAML example that says Helm can create that ResourceQuota?

Suggested wording to insert right after the YAML example:

Note: Installing the istio-cni Helm chart with --set global.platform=gke (see the Helm example below) will automatically create the ResourceQuota shown above.

If you add that there, please remove the duplicate sentence from the “Platform profile” here (or replace it with a short cross-reference like “(See note above about ResourceQuota creation.)”).

Copy link
Copy Markdown
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants