Add Import Files... command that supports many file types#1764
Add Import Files... command that supports many file types#1764isc-bsaviano wants to merge 2 commits intointersystems-community:masterfrom
Import Files... command that supports many file types#1764Conversation
isc-klu
left a comment
There was a problem hiding this comment.
Why aren’t we concerned about key bindings for other command IDs? Do they simply not appear in the telemetry data?
|
We capture no telemetry data on user keybindings. It should be possible to add. |
|
That helps, thanks. I’m curious why we were comfortable deleting |
|
@isc-klu We have telemetry on command execution. Over the past 90 days, |
|
I updated the command ID |
|
I see — that makes sense. Updating importXMLFiles clearly incurs a higher documentation burden, given the dedicated docs page it already has. If backward compatibility is a strong requirement here, I think the right approach would be to introduce the new command ( If we’re comfortable with a breaking change, then the current approach—removing the old commands outright—is reasonable and probably the simplest path. |
|
This is going to be a nontrivial documentation effort no matter what the command ID is. The only question is if we should keep the same command name to preserve any custom keybindings. Since the command's functionality changed meaningfully, I think a new ID is warranted. |
This PR fixes #1763 by removing restrictions on the existing
Import XML Files...command. The underlying server APIs support many file types, so it's easy for VS Code to do so as well. This also make theImport Local Files...command redundant, so I removed it. I kept thevscode-objectscript.importXMLFilescommand ID in case anyone made a keybinding for it, but I am also open to changing it to something likevscode-objectscript.importFiles.