Skip to content

Add Import Files... command that supports many file types#1764

Open
isc-bsaviano wants to merge 2 commits intointersystems-community:masterfrom
isc-bsaviano:fix-1763
Open

Add Import Files... command that supports many file types#1764
isc-bsaviano wants to merge 2 commits intointersystems-community:masterfrom
isc-bsaviano:fix-1763

Conversation

@isc-bsaviano
Copy link
Copy Markdown
Contributor

This PR fixes #1763 by removing restrictions on the existing Import XML Files... command. The underlying server APIs support many file types, so it's easy for VS Code to do so as well. This also make the Import Local Files... command redundant, so I removed it. I kept the vscode-objectscript.importXMLFiles command ID in case anyone made a keybinding for it, but I am also open to changing it to something like vscode-objectscript.importFiles.

Copy link
Copy Markdown
Collaborator

@isc-klu isc-klu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren’t we concerned about key bindings for other command IDs? Do they simply not appear in the telemetry data?

@isc-bsaviano
Copy link
Copy Markdown
Contributor Author

We capture no telemetry data on user keybindings. It should be possible to add.

@isc-klu
Copy link
Copy Markdown
Collaborator

isc-klu commented Apr 17, 2026

That helps, thanks. I’m curious why we were comfortable deleting importLocalFilesServerSide, but chose to preserve importXMLFiles. Is there a reason to believe the latter is more heavily used or more likely to be bound by users?

@isc-bsaviano
Copy link
Copy Markdown
Contributor Author

@isc-klu We have telemetry on command execution. Over the past 90 days, importLocalFilesServerSide has been run 453 times, while importXMLFiles has been run 1033. XML also has it's own documentation page, which the other has a small reference. I am fine with changing the command ID. We do not have any good reason to believe that someone has assigned either command to a keybinding. The docs will need to be updated regardless.

@isc-bsaviano
Copy link
Copy Markdown
Contributor Author

I updated the command ID

@isc-klu
Copy link
Copy Markdown
Collaborator

isc-klu commented Apr 20, 2026

I see — that makes sense. Updating importXMLFiles clearly incurs a higher documentation burden, given the dedicated docs page it already has.

If backward compatibility is a strong requirement here, I think the right approach would be to introduce the new command (importFiles) and make all existing commands aliases of it.

If we’re comfortable with a breaking change, then the current approach—removing the old commands outright—is reasonable and probably the simplest path.

@isc-bsaviano
Copy link
Copy Markdown
Contributor Author

This is going to be a nontrivial documentation effort no matter what the command ID is. The only question is if we should keep the same command name to preserve any custom keybindings. Since the command's functionality changed meaningfully, I think a new ID is warranted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import from local file does not work for .mac, .rtn, .int, .inc and .xml

2 participants