Open
Conversation
edburns
requested changes
Apr 20, 2026
Collaborator
edburns
left a comment
edburns
left a comment
There was a problem hiding this comment.
@copilot This is a precipitous drop: 84.4 → 69.2.
Please add effective and useful automated tests to get this number back up to >= 85.
- Write new automated tests that cover the generated code. Take a look at what was done in PR #81 . This PR added the generated code.
- Ensure any existing tests that exercised code formerly in
src/main/.../events/are rewritten to exercise the corresponding new code insrc/generated/java/com/github/copilot/sdk/generated/. - Write tests for these new classes in
generated
RPC types (~120 files) —ServerRpc.java,SessionRpc.java, sub-API classes (SessionToolsApi,SessionUiApi, etc.), and param/result records for every RPC method.
Use Mockito as necessary. Recall that Mockito is now a test dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated JaCoCo coverage badge update from CI.