fix(cli): accumulate multiple --add-dir flags into array (#1215)#1232
Open
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Open
fix(cli): accumulate multiple --add-dir flags into array (#1215)#1232xodn348 wants to merge 1 commit intoanthropics:mainfrom
xodn348 wants to merge 1 commit intoanthropics:mainfrom
Conversation
…1215) Add 'add-dir' to ACCUMULATING_FLAGS set so that multiple --add-dir flags passed via claude_args are joined with null-char delimiter instead of the last value overwriting previous ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1215 - When multiple
--add-dirflags are passed viaclaude_args, only the last value was kept due to overwrite semantics. This PR adds"add-dir"to theACCUMULATING_FLAGSset so that all values are properly accumulated using the null-char delimiter, consistent with how--allowed-tools,--disallowed-tools, and--mcp-configalready work.Changes
"add-dir"toACCUMULATING_FLAGSinbase-action/src/parse-sdk-options.tsTesting