Skip to content

CI: accept --runID in uploadMetadata, emit run_id on Pub/Sub #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openroad-ci wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

CI: accept --runID in uploadMetadata, emit run_id on Pub/Sub #4169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flow/util/uploadMetadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
parser.add_argument(
"--pubsubCred", type=str, help="Service account credentials file for Pub/Sub"
)
parser.add_argument("--runID", type=str, help="Unique identifier for this CI run")
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The --runID argument is added within the Pub/Sub specific arguments block. However, the motivation describes it as a general identifier for the CI run (similar to buildID or pipelineID). Consider moving it to the general arguments section (near line 29). Furthermore, while this PR updates the Pub/Sub payload, it appears to miss adding run_id to the Firestore upload_data payload (around line 63). To ensure data consistency across both backends while Firestore is still supported, please include run_id in the Firestore document as well.

# --- END PUBSUB args ---

# Parse the arguments
Expand Down Expand Up @@ -209,6 +210,7 @@ def publish_to_pubsub(
"change_branch": args.changeBranch,
"commit_sha": args.commitSHA,
"jenkins_url": args.jenkinsURL,
"run_id": args.runID,
"rules": rules,
}

Expand Down