Skip to content

Commit 4de3bce

Browse files
committed
SONARJAVA-5122 S5977: repaired integration tests, updated README
1 parent 71fd30a commit 4de3bce

File tree

6 files changed

+25
-10
lines changed

6 files changed

+25
-10
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ To run the test, first make sure the submodules are checked out:
114114

115115
git submodule update --init --recursive
116116

117-
Then, ensure that the `JAVA_HOME` environment variable is set for the ruling tests execution and that it points to your local JDK 17 installation.
117+
Then, ensure that the `JAVA_HOME` environment variable is set for the ruling tests execution and that it points to your local JDK 21 installation.
118118
Failing to do so will produce inconsistencies with the expected results.
119119

120120
From the `its/ruling` folder, launch the ruling tests:
@@ -186,7 +186,7 @@ For more detailed information, you can compare the differences between the resul
186186
* [java-checks-test-sources-no-binaries](its/autoscan/target/actual/java-checks-test-sources-no-binaries)
187187

188188
Depending on the results found, you might need to update the ground truth.
189-
The expected results are listed in [src/test/resources](its/autoscan/src/test/resources/autoscan/).
189+
The expected results are listed in [src/test/resources](its/autoscan/src/test/resources/autoscan/diffs).
190190

191191
#### Debugging Integration Tests
192192
You can debug ITs by adding `-Dmaven.binary=mvnDebug` as an option when running the tests. This will cause the analyzer JVM to wait for a debugger to be attached before continuing.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"ruleKey": "S2119",
33
"hasTruePositives": true,
4-
"falseNegatives": 0,
4+
"falseNegatives": 2,
55
"falsePositives": 0
6-
}
6+
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"ruleKey": "S2245",
33
"hasTruePositives": true,
4-
"falseNegatives": 25,
4+
"falseNegatives": 26,
55
"falsePositives": 0
66
}

its/ruling/src/test/resources/eclipse-jetty/java-S5977.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,18 @@
88
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/StressTest.java": [
99
73
1010
],
11+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/ThreadStarvationTest.java": [
12+
114
13+
],
14+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/handler/DebugHandlerTest.java": [
15+
123
16+
],
17+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLCloseTest.java": [
18+
61
19+
],
20+
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLEngineTest.java": [
21+
143
22+
],
1123
"org.eclipse.jetty:jetty-project:jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLSelectChannelConnectorLoadTest.java": [
1224
237
1325
],
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/user/UserUpdater.java": [
3+
378
4+
],
5+
"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/usertoken/TokenGeneratorImpl.java": [
6+
29
7+
]
8+
}

java-checks-test-sources/default/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,11 +1011,6 @@
10111011
<artifactId>vavr</artifactId>
10121012
<version>0.10.4</version>
10131013
</dependency>
1014-
<dependency>
1015-
<groupId>org.jspecify</groupId>
1016-
<artifactId>jspecify</artifactId>
1017-
<version>1.0.0</version>
1018-
</dependency>
10191014
<dependency>
10201015
<groupId>org.junit.platform</groupId>
10211016
<artifactId>junit-platform-suite</artifactId>

0 commit comments

Comments
 (0)