SONARJAVA-5122 S5977: extend rule to be applied for all Random subclasses

Author: asya-vorobeva

java-checks-test-sources/default/src/test/java/checks/tests/RandomizedTestDataCheckSample.java

@@ -1,11 +1,13 @@
 package checks.tests;
 
+import java.security.SecureRandom;
 import java.util.Random;
 import java.util.UUID;
+
+import org.apache.commons.lang.math.JVMRandom;
 import org.junit.jupiter.api.Test;
 
 public class RandomizedTestDataCheckSample {
-
   @Test
   public void randomizedTest() {
 
@@ -36,6 +38,13 @@ public void randomizedTest() {
     int age5 = new Random().nextInt(42);
 //             ^^^^^^^^^^^^<
     MyRandom myRandom = new MyRandom(); // Compliant
+
+    Random random = new Random();
+//                  ^^^^^^^^^^^^<
+    SecureRandom random1 = new SecureRandom();
+//                         ^^^^^^^^^^^^^^^^^^<
+    int age6 = new JVMRandom().nextInt(34);
+//             ^^^^^^^^^^^^^^^<
   }
 
   @Test

java-checks/src/main/java/org/sonar/java/checks/tests/RandomizedTestDataCheck.java

@@ -32,7 +32,7 @@
 public class RandomizedTestDataCheck extends IssuableSubscriptionVisitor {
 
   private static final MethodMatchers RANDOM_CONSTRUCTOR_METHOD_MATCHER = MethodMatchers.create()
-    .ofTypes("java.util.Random")
+    .ofSubTypes("java.util.Random")
     .constructor()
     .withAnyParameters()
     .build();