Skip to content

update(flake): from github:astro/microvm.nix to github:microvm-nix/microvm.nix#1115

Open
Malix-Labs wants to merge 3 commits intoNixOS:mainfrom
Malix-Labs:patch-11
Open

update(flake): from github:astro/microvm.nix to github:microvm-nix/microvm.nix#1115
Malix-Labs wants to merge 3 commits intoNixOS:mainfrom
Malix-Labs:patch-11

Conversation

@Malix-Labs
Copy link
Copy Markdown
Contributor

@Malix-Labs Malix-Labs commented Dec 8, 2025

Copilot AI review requested due to automatic review settings December 8, 2025 13:20
@Malix-Labs Malix-Labs changed the title update(flake): from github:astro/microvm.nix to `github:microvm-nix… update(flake): from github:astro/microvm.nix to github:microvm-nix/microvm.nix Dec 8, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the flake source reference for microvm.nix from the old repository (github:astro/microvm.nix) to the new official repository (github:microvm-nix/microvm.nix). The change reflects an upstream repository migration.

  • Moved the microvm.nix source entry from owner "astro" to "microvm-nix"
  • Updated the issue reporting URL in the comment to point to the new repository location
  • Maintained alphabetical ordering by relocating the entry between Mic92 and mirrexagon

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@raboof
Copy link
Copy Markdown
Member

raboof commented Dec 8, 2025

While I indeed see the move, I get an error evaluating it:

nix run .#flake-info -- --json flake github:microvm-nix/microvm.nix
warning: Git tree '/home/aengelen/dev/nixos/nixos-search' is dirty
warning: ignoring untrusted flake configuration setting 'extra-substituters'.
Pass '--accept-flake-config' to trust it
warning: ignoring untrusted flake configuration setting 'extra-trusted-public-keys'.
Pass '--accept-flake-config' to trust it
[2025-12-08T13:39:58Z ERROR command_run] command 'nix eval --json --no-allow-import-from-derivation --no-write-lock-file -f '/nix/store/qs1mwb04ia7jnd3k61fk52w0n9qc20l9-flake-info/assets/commands/flake_info.nix' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixpkgs-unstable.tar.gz --override-flake input-flake github:microvm-nix/microvm.nix --argstr flake github:microvm-nix/microvm.nix all' failed: exit status: 1
    stdout:
    
    stderr:
    copying path '/nix/store/9v6qa656sq3xc58vkxslqy646p0ajj61-source' from 'https://cache.nixos.org'...
    error:
           … while evaluating a branch condition
             at /nix/store/qs1mwb04ia7jnd3k61fk52w0n9qc20l9-flake-info/assets/commands/flake_info.nix:221:5:
              220|     # are multiple modules
              221|     if nixosModulesOpts != [ ] then nixosModulesOpts else nixosModuleOpts;
                 |     ^
              222|
    
           … while calling the 'concatLists' builtin
             at /nix/store/qs1mwb04ia7jnd3k61fk52w0n9qc20l9-flake-info/assets/commands/flake_info.nix:201:26:
              200|     let
              201|       nixosModulesOpts = builtins.concatLists (
                 |                          ^
              202|         lib.mapAttrsToList (
    
           … while evaluating the option `microvm.firecracker.extraConfig._module.freeformType':
    
           … while evaluating definitions from `/nix/store/yp0z6h793yi3j53r0fzy8kw7qwxz46pw-source/nixos-modules/microvm/options.nix':
    
           … while evaluating the module argument `pkgs' in "/nix/store/yp0z6h793yi3j53r0fzy8kw7qwxz46pw-source/nixos-modules/microvm/options.nix":
    
           … noting that argument `pkgs` is not externally provided, so querying `_module.args` instead, requiring `config`
    
           (stack trace truncated; use '--show-trace' to show the full, detailed trace)
    
           error: attribute 'pkgs' missing
           at /nix/store/9rf7z9hhnxqvbf5i04labfsxill2zhyl-source/lib/modules.nix:685:13:
              684|             "noting that argument `${name}` is not externally provided, so querying `_module.args` instead, requiring `config`"
              685|             config._module.args.${name}
                 |             ^
              686|           )
    
Error: Getting flake info caused an error: Failed to gather information about github:microvm-nix/microvm.nix

Caused by:
    command 'nix eval --json --no-allow-import-from-derivation --no-write-lock-file -f '/nix/store/qs1mwb04ia7jnd3k61fk52w0n9qc20l9-flake-info/assets/commands/flake_info.nix' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixpkgs-unstable.tar.gz --override-flake input-flake github:microvm-nix/microvm.nix --argstr flake github:microvm-nix/microvm.nix all' failed: exit status: 1

Would you like to create an upstream issue?

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented Dec 8, 2025

@raboof are you sure it isn't a problem with flake-info?

i'm not using microvm-nix personally but i tried to understand the issue;
it might be because the flake need to be called with an argument / the desired output

nix flake show github:microvm-nix/microvm.nix seems to take ages to complete

https://github.com/microvm-nix/microvm.nix/blob/main/flake.nix

@raboof
Copy link
Copy Markdown
Member

raboof commented Dec 8, 2025

@raboof are you sure it isn't a problem with flake-info?

it's very possible that this is a problem with flake-info, but I don't think anyone is actively developing flake-info at this point, so if it can't process a flake and someone would like it to be in the search (which it looks like they would), I think it's reasonable to ask them to help look into this.

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

Malix-Labs commented Dec 8, 2025

@raboof what is missing from nix flake metadata / nix flake show to not being able to replace flake-info?

@raboof
Copy link
Copy Markdown
Member

raboof commented Dec 8, 2025

I don't know, would indeed be interesting to compare

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

See #1117

@Malix-Labs
Copy link
Copy Markdown
Contributor Author

The problem is most probably not from flake-info

@raboof
Copy link
Copy Markdown
Member

raboof commented Dec 9, 2025

filed microvm-nix/microvm.nix#443

@miniBill miniBill added flakes flake PRs that add/update flakes and removed flakes labels Feb 11, 2026
@Malix-Labs Malix-Labs force-pushed the patch-11 branch 3 times, most recently from a908b08 to 0ca6164 Compare February 12, 2026 01:01
@Malix-Labs Malix-Labs marked this pull request as draft February 12, 2026 01:03
@Malix-Labs Malix-Labs marked this pull request as ready for review February 12, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flake PRs that add/update flakes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants