Consistent evaluation of Tricomi U(a,b,z)#92
Open
AshtonSBradley wants to merge 2 commits intoJuliaMath:masterfrom
Open
Consistent evaluation of Tricomi U(a,b,z)#92AshtonSBradley wants to merge 2 commits intoJuliaMath:masterfrom
AshtonSBradley wants to merge 2 commits intoJuliaMath:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
+ Coverage 84.89% 85.17% +0.27%
==========================================
Files 7 7
Lines 1470 1511 +41
==========================================
+ Hits 1248 1287 +39
- Misses 222 224 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks for this @AshtonSBradley! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #61 , #63, adding tests from #63, and additional tests to increase PR coverage.
Reworked
U(a,b,z)in src/confluent.jl (line 42) so it no longer relies on the large-|z|asymptotic formula for every case. The new implementation uses the exact DLMF connection formula for nonintegerb, the integer-bseries from DLMF 13.2.9, Kummer’s transformation for nonpositive integerb, and a polynomial path whenais a nonpositive integer. DirectU(1,1,z)evaluation also added for stability.The regression tests in test/runtests.jl (line 603) now cover the negative-real-axis cases from issue #63 plus the real-negative input behaviour that used to throw. Pkg.test() passes.
The key formulas used were DLMF 13.2.42, 13.2.9, and Kummer’s transformation as noted in issue #61.