Harden Linux manager executable lookup to prevent PATH hijacking#4621
Open
mmorrissette-devolutions wants to merge 1 commit intomainfrom
Open
Harden Linux manager executable lookup to prevent PATH hijacking#4621mmorrissette-devolutions wants to merge 1 commit intomainfrom
mmorrissette-devolutions wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
apt,dnf, andpacmanbinaries were discovered from the userPATHand later invoked under an elevator (sudo/pkexec), which allowed a PATH-hijacked binary to be run as root after user approval.PATHinfluence.Description
FindCandidateExecutableFiles()insrc/UniGetUI.PackageEngine.Managers.Apt/Apt.csto only consider/usr/bin/aptand/bin/aptinstead of usingCoreTools.WhichMultiple("apt").FindCandidateExecutableFiles()insrc/UniGetUI.PackageEngine.Managers.Dnf/Dnf.csto only consider/usr/bin/dnf5,/usr/bin/dnf,/bin/dnf5, and/bin/dnfand removedWhichMultipleusage fordnfcandidates.FindCandidateExecutableFiles()insrc/UniGetUI.PackageEngine.Managers.Pacman/Pacman.csto only consider/usr/bin/pacmanand/bin/pacmaninstead of usingCoreTools.WhichMultiple("pacman").Testing
dotnet --versionreturnedcommand not foundsodotnet testcould not be run.Codex Task