fix for coverity issue 394676 possible null dereference

JacobBarthelmeh · JacobBarthelmeh · commit f8eb0c3776f3 · 2024-07-05T14:06:19.000-06:00
diff --git a/src/ssl_load.c b/src/ssl_load.c
@@ -5496,7 +5496,7 @@ long wolfSSL_set_tmp_dh(WOLFSSL *ssl, WOLFSSL_DH *dh)
         ret = wolfssl_set_tmp_dh(ssl, p, pSz, g, gSz);
     }
 
-    if (ret != 1) {
+    if (ret != 1 && ssl != NULL) {
         /* Free the allocated buffers if not assigned into SSL. */
         XFREE(p, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);
         XFREE(g, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);

Original file line number	Diff line number	Diff line change
`@@ -5496,7 +5496,7 @@ long wolfSSL_set_tmp_dh(WOLFSSL ssl, WOLFSSL_DH dh)`
`5496`	`5496`	`ret = wolfssl_set_tmp_dh(ssl, p, pSz, g, gSz);`
`5497`	`5497`	`}`
`5498`	`5498`
`5499`		`- if (ret != 1) {`
	`5499`	`+ if (ret != 1 && ssl != NULL) {`
`5500`	`5500`	`/* Free the allocated buffers if not assigned into SSL. */`
`5501`	`5501`	`XFREE(p, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);`
`5502`	`5502`	`XFREE(g, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);`