Merge pull request #9003 from embhorn/cov_531298

JacobBarthelmeh · web-flow · commit 9430c8a5a183 · 2025-07-14T16:20:19.000-06:00
Fix blake2b_final coverity reports
diff --git a/wolfcrypt/src/blake2b.c b/wolfcrypt/src/blake2b.c
@@ -356,9 +356,9 @@ int blake2b_final( blake2b_state *S, byte *out, byte outlen )
     }
 
     S->buflen -= BLAKE2B_BLOCKBYTES;
-    if ( S->buflen >= (BLAKE2B_BLOCKBYTES * 2) )
+    if ( S->buflen > BLAKE2B_BLOCKBYTES )
       return BAD_LENGTH_E;
-    XMEMCPY( S->buf, S->buf + BLAKE2B_BLOCKBYTES, (wolfssl_word)S->buflen );
+    XMEMMOVE( S->buf, S->buf + BLAKE2B_BLOCKBYTES, (wolfssl_word)S->buflen );
   }
 
   blake2b_increment_counter( S, S->buflen );

Original file line number	Diff line number	Diff line change
`@@ -356,9 +356,9 @@ int blake2b_final( blake2b_state S, byte out, byte outlen )`
`356`	`356`	`}`
`357`	`357`
`358`	`358`	`S->buflen -= BLAKE2B_BLOCKBYTES;`
`359`		`- if ( S->buflen >= (BLAKE2B_BLOCKBYTES * 2) )`
	`359`	`+ if ( S->buflen > BLAKE2B_BLOCKBYTES )`
`360`	`360`	`return BAD_LENGTH_E;`
`361`		`- XMEMCPY( S->buf, S->buf + BLAKE2B_BLOCKBYTES, (wolfssl_word)S->buflen );`
	`361`	`+ XMEMMOVE( S->buf, S->buf + BLAKE2B_BLOCKBYTES, (wolfssl_word)S->buflen );`
`362`	`362`	`}`
`363`	`363`
`364`	`364`	`blake2b_increment_counter( S, S->buflen );`