Skip to content

Commit 52ba700

Browse files
CID 426426 code maintainability warning, stored NULL value overwritten before used
1 parent 077b070 commit 52ba700

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/x509_str.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1754,7 +1754,7 @@ WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* wolfSSL_X509_STORE_get0_objects(
17541754
* simplify cleanup logic handling cert merging above */
17551755
for (i = 0; i < wolfSSL_sk_X509_num(cert_stack); i++) {
17561756
x509 = (WOLFSSL_X509 *)wolfSSL_sk_value(cert_stack, i);
1757-
obj = wolfSSL_X509_OBJECT_new();
1757+
obj = wolfSSL_X509_OBJECT_new();
17581758
if (obj == NULL) {
17591759
WOLFSSL_MSG("wolfSSL_X509_OBJECT_new error");
17601760
goto err_cleanup;
@@ -1766,10 +1766,9 @@ WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* wolfSSL_X509_STORE_get0_objects(
17661766
}
17671767
obj->type = WOLFSSL_X509_LU_X509;
17681768
obj->data.x509 = x509;
1769-
x509 = NULL;
17701769
}
17711770

1772-
while(wolfSSL_sk_X509_num(cert_stack) > 0) {
1771+
while (wolfSSL_sk_X509_num(cert_stack) > 0) {
17731772
wolfSSL_sk_X509_pop(cert_stack);
17741773
}
17751774
#endif
@@ -1799,7 +1798,7 @@ WOLF_STACK_OF(WOLFSSL_X509_OBJECT)* wolfSSL_X509_STORE_get0_objects(
17991798
if (ret != NULL)
18001799
X509StoreFreeObjList(store, ret);
18011800
if (cert_stack != NULL) {
1802-
while(store->numAdded > 0) {
1801+
while (store->numAdded > 0) {
18031802
wolfSSL_sk_X509_pop(cert_stack);
18041803
store->numAdded--;
18051804
}

0 commit comments

Comments
 (0)