fix coverity issue 367842 possible null dereference

JacobBarthelmeh · JacobBarthelmeh · commit 25d52dde3f7d · 2024-07-05T11:56:45.000-06:00
diff --git a/src/ssl_load.c b/src/ssl_load.c
@@ -5264,7 +5264,7 @@ int wolfSSL_SetTmpDH(WOLFSSL* ssl, const unsigned char* p, int pSz,
         ret = wolfssl_set_tmp_dh(ssl, pAlloc, pSz, gAlloc, gSz);
     }
 
-    if (ret != 1) {
+    if (ret != 1 && ssl != NULL) {
         /* Free the allocated buffers if not assigned into SSL. */
         XFREE(pAlloc, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);
         XFREE(gAlloc, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);

Original file line number	Diff line number	Diff line change
`@@ -5264,7 +5264,7 @@ int wolfSSL_SetTmpDH(WOLFSSL* ssl, const unsigned char* p, int pSz,`
`5264`	`5264`	`ret = wolfssl_set_tmp_dh(ssl, pAlloc, pSz, gAlloc, gSz);`
`5265`	`5265`	`}`
`5266`	`5266`
`5267`		`- if (ret != 1) {`
	`5267`	`+ if (ret != 1 && ssl != NULL) {`
`5268`	`5268`	`/* Free the allocated buffers if not assigned into SSL. */`
`5269`	`5269`	`XFREE(pAlloc, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);`
`5270`	`5270`	`XFREE(gAlloc, ssl->heap, DYNAMIC_TYPE_PUBLIC_KEY);`