test: fix (#1160)

Author: alexander-akait

package-lock.json

@@ -61,9 +61,6 @@
     "@babel/preset-env": "^7.24.4",
     "@commitlint/cli": "^17.5.1",
     "@commitlint/config-conventional": "^17.4.4",
-    "@eslint/js": "^9.32.0",
-    "@eslint/markdown": "^7.0.0",
-    "@stylistic/eslint-plugin": "^5.2.2",
     "@types/node": "^18.15.11",
     "bootstrap": "^4.6.2",
     "cross-env": "^7.0.3",
@@ -73,16 +70,8 @@
     "del-cli": "^4.0.0",
     "es-check": "^7.1.0",
     "eslint": "^9.32.0",
-    "eslint-config-prettier": "^10.1.8",
     "eslint-config-webpack": "^4.4.2",
-    "eslint-plugin-import": "^2.32.0",
-    "eslint-plugin-jest": "^29.0.1",
-    "eslint-plugin-jsdoc": "^62.0.0",
-    "eslint-plugin-n": "^17.21.0",
-    "eslint-plugin-prettier": "^5.5.3",
-    "eslint-plugin-unicorn": "^62.0.0",
     "file-loader": "^6.2.0",
-    "globals": "^17.0.0",
     "husky": "^7.0.0",
     "jest": "^28.1.3",
     "jest-environment-jsdom": "^28.1.3",
@@ -96,7 +85,6 @@
     "sass-loader": "^12.6.0",
     "standard-version": "^9.3.0",
     "typescript": "^5.8.0",
-    "typescript-eslint": "^8.38.0",
     "webpack": "^5.102.0",
     "webpack-cli": "^4.9.2",
     "webpack-dev-server": "^5.2.1"

package.json

@@ -49,7 +49,7 @@ const {
  * @property {boolean=} ignoreOrder true when need to ignore order, otherwise false
  * @property {string | ((linkTag: HTMLLinkElement) => void)=} insert link insert place or a custom insert function
  * @property {Record<string, string>=} attributes link attributes
- * @property {string | false | 'text/css'=} linkType value of a link type attribute
+ * @property {string | false | "text/css"=} linkType value of a link type attribute
  * @property {boolean=} runtime true when need to generate runtime code, otherwise false
  * @property {boolean=} experimentalUseImportModule true when need to use `experimentalUseImportModule` API, otherwise false
  */
@@ -61,15 +61,15 @@ const {
  * @property {boolean} ignoreOrder true when need to ignore order, otherwise false
  * @property {string | ((linkTag: HTMLLinkElement) => void)=} insert a link insert place or a custom insert function
  * @property {Record<string, string>=} attributes link attributes
- * @property {string | false | 'text/css'=} linkType value of a link type attribute
+ * @property {string | false | "text/css"=} linkType value of a link type attribute
  * @property {boolean} runtime true when need to generate runtime code, otherwise false
  * @property {boolean=} experimentalUseImportModule true when need to use `experimentalUseImportModule` API, otherwise false
  */
 
 /**
  * @typedef {object} RuntimeOptions
  * @property {string | ((linkTag: HTMLLinkElement) => void)=} insert a link insert place or a custom insert function
- * @property {string | false | 'text/css'} linkType value of a link type attribute
+ * @property {string | false | "text/css"} linkType value of a link type attribute
  * @property {Record<string, string>=} attributes link attributes
  */
 
@@ -90,12 +90,12 @@ const CODE_GENERATION_RESULT = {
 };
 
 // eslint-disable-next-line jsdoc/reject-any-type
-/** @typedef {{ context: string | null, identifier: string, identifierIndex: number, content: Buffer, sourceMap?: Buffer, media?: string, supports?: string, layer?: any, assetsInfo?: Map<string, AssetInfo>, assets?: { [key: string]: Source }}} CssModuleDependency */
+/** @typedef {{ context: string | null, identifier: string, identifierIndex: number, content: Buffer, sourceMap?: Buffer, media?: string, supports?: string, layer?: any, assetsInfo?: Map<string, AssetInfo>, assets?: { [key: string]: Source } }} CssModuleDependency */
 /** @typedef {Module & { content: Buffer, media?: string, sourceMap?: Buffer, supports?: string, layer?: string, assets?: { [key: string]: Source }, assetsInfo?: Map<string, AssetInfo> }} CssModule */
-/** @typedef {{ new(dependency: CssModuleDependency): CssModule }} CssModuleConstructor */
+/** @typedef {{ new (dependency: CssModuleDependency): CssModule }} CssModuleConstructor */
 /** @typedef {Dependency & CssModuleDependency} CssDependency */
 /** @typedef {Omit<LoaderDependency, "context">} CssDependencyOptions */
-/** @typedef {{ new(loaderDependency: CssDependencyOptions, context: string | null, identifierIndex: number): CssDependency }} CssDependencyConstructor */
+/** @typedef {{ new (loaderDependency: CssDependencyOptions, context: string | null, identifierIndex: number): CssDependency }} CssDependencyConstructor */
 
 /**
  * @typedef {object} VarNames

src/index.js

@@ -25,7 +25,7 @@ const MiniCssExtractPlugin = require("./index");
 /** @typedef {import("./index.js").LoaderOptions} LoaderOptions */
 
 // eslint-disable-next-line jsdoc/reject-function-type
-/** @typedef {{[key: string]: string | Function }} Locals */
+/** @typedef {{ [key: string]: string | Function }} Locals */
 
 // eslint-disable-next-line jsdoc/reject-any-type
 /** @typedef {any} EXPECTED_ANY */

src/loader.js

@@ -233,7 +233,7 @@ const toSimpleString = (str) => {
 const quoteMeta = (str) => str.replace(/[-[\]\\/{}()*+?.^$|]/g, "\\$&");
 
 /**
- * @param {Array<string>} items items
+ * @param {string[]} items items
  * @returns {string} common prefix
  */
 const getCommonPrefix = (items) => {
@@ -253,7 +253,7 @@ const getCommonPrefix = (items) => {
 };
 
 /**
- * @param {Array<string>} items items
+ * @param {string[]} items items
  * @returns {string} common suffix
  */
 const getCommonSuffix = (items) => {
@@ -279,27 +279,27 @@ const getCommonSuffix = (items) => {
 /**
  * @param {Set<string>} itemsSet items set
  * @param {(str: string) => string | false} getKey get key function
- * @param {(str: Array<string>) => boolean} condition condition
- * @returns {Array<Array<string>>} list of common items
+ * @param {(str: string[]) => boolean} condition condition
+ * @returns {string[][]} list of common items
  */
 const popCommonItems = (itemsSet, getKey, condition) => {
-  /** @type {Map<string, Array<string>>} */
+  /** @type {Map<string, string[]>} */
   const map = new Map();
 
   for (const item of itemsSet) {
     const key = getKey(item);
     if (key) {
       let list = map.get(key);
       if (list === undefined) {
-        /** @type {Array<string>} */
+        /** @type {string[]} */
         list = [];
         map.set(key, list);
       }
       list.push(item);
     }
   }
 
-  /** @type {Array<Array<string>>} */
+  /** @type {string[][]} */
   const result = [];
 
   for (const list of map.values()) {
@@ -315,15 +315,15 @@ const popCommonItems = (itemsSet, getKey, condition) => {
 };
 
 /**
- * @param {Array<string>} itemsArr array of items
+ * @param {string[]} itemsArr array of items
  * @returns {string} regexp
  */
 const itemsToRegexp = (itemsArr) => {
   if (itemsArr.length === 1) {
     return quoteMeta(itemsArr[0]);
   }
 
-  /** @type {Array<string>} */
+  /** @type {string[]} */
   const finishedItems = [];
 
   // merge single char items: (a|b|c|d|ef) => ([abcd]|ef)

src/utils.js

@@ -1,7 +1,6 @@
 /**
  * @jest-environment jsdom
  */
-/* global document */
 
 import hotModuleReplacement from "../src/hmr/hotModuleReplacement";
 import { hotLoader } from "../src/loader";
@@ -26,9 +25,9 @@ describe("HMR", () => {
   let consoleMock = null;
 
   beforeEach(() => {
-    consoleMock = jest.spyOn(console, "log").mockImplementation(() => () => {});
+    consoleMock = jest.spyOn(console, "log").mockReturnValue(() => {});
 
-    jest.spyOn(Date, "now").mockImplementation(() => 1479427200000);
+    jest.spyOn(Date, "now").mockReturnValue(1479427200000);
 
     document.head.innerHTML = '<link rel="stylesheet" href="/dist/main.css" />';
     document.body.innerHTML = '<script src="/dist/main.js"></script>';
@@ -80,7 +79,7 @@ describe("HMR", () => {
 
       expect(links[1].isLoaded).toBe(true);
 
-      jest.spyOn(Date, "now").mockImplementation(() => 1479427200001);
+      jest.spyOn(Date, "now").mockReturnValue(1479427200001);
 
       const update2 = hotModuleReplacement("./src/style.css", {});
 

test/HMR.test.js

@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
 /******/ 	
 /******/ 	/* webpack/runtime/getFullHash */
 /******/ 	(() => {
-/******/ 		__webpack_require__.h = () => ("656f51af10a65a287c7e")
+/******/ 		__webpack_require__.h = () => ("0ca34a06508c170bc52a")
 /******/ 	})();
 /******/ 	
 /******/ 	/* webpack/runtime/global */