Skip to content

Commit 73b4671

Browse files
authored
No error message when PR diff fails to open (#8360)
Fixes #8350
1 parent 13ddd79 commit 73b4671

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/uriHandler.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,15 @@ export class UriHandler implements vscode.UriHandler {
139139
private async _resolvePullRequestFromUri(uri: vscode.Uri): Promise<{ folderManager: FolderRepositoryManager; pullRequest: PullRequestModel } | undefined> {
140140
const params = fromOpenOrCheckoutPullRequestWebviewUri(uri);
141141
if (!params) {
142+
vscode.window.showErrorMessage(vscode.l10n.t('Invalid pull request URI.'));
143+
Logger.error('Failed to parse pull request URI.', UriHandler.ID);
142144
return;
143145
}
144146
const folderManager = this._reposManagers.getManagerForRepository(params.owner, params.repo) ?? this._reposManagers.folderManagers[0];
145147
const pullRequest = await folderManager.resolvePullRequest(params.owner, params.repo, params.pullRequestNumber);
146148
if (!pullRequest) {
149+
vscode.window.showErrorMessage(vscode.l10n.t('Pull request {0}/{1}#{2} not found.', params.owner, params.repo, params.pullRequestNumber));
150+
Logger.error(`Pull request not found: ${params.owner}/${params.repo}#${params.pullRequestNumber}`, UriHandler.ID);
147151
return;
148152
}
149153
return { folderManager, pullRequest };

0 commit comments

Comments
 (0)