Skip to content

Commit 705a4a7

Browse files
committed
CCR feedback
1 parent 79431e4 commit 705a4a7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/view/reviewManager.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ export class ReviewManager extends Disposable {
231231
await this.updateState();
232232
}
233233
} catch (e) {
234-
Logger.warn(`Polling for state change failed: ${e}`, this.id);
234+
Logger.warn(`Polling for state change failed: ${formatError(e)}`, this.id);
235235
} finally {
236236
if (!this.isDisposed) {
237237
this.pollForStateChange();
@@ -470,7 +470,7 @@ export class ReviewManager extends Disposable {
470470
result.add(headRepo);
471471
return [...result];
472472
} catch (e) {
473-
Logger.warn(`Failed to get metadata for relevant repos: ${e}`, this.id);
473+
Logger.warn(`Failed to get metadata for relevant repos: ${formatError(e)}`, this.id);
474474
return [headRepo];
475475
}
476476
}
@@ -493,9 +493,9 @@ export class ReviewManager extends Disposable {
493493
return true;
494494
}
495495
const current = await this.getMaxPullRequestNumbers();
496-
// If we couldn't determine max PR for any repo, assume there may be new PRs
496+
// If we couldn't determine max PR for any repo, assume there may be new PRs,
497+
// but keep the last known good cache so transient failures do not discard it.
497498
if (current.size === 0) {
498-
this._cachedMaxPRNumbers = current;
499499
return true;
500500
}
501501
let result = false;

0 commit comments

Comments
 (0)