Skip to content

Commit 729de2b

Browse files
authored
label-issues: Invert functional impact label logic (#48)
Fixes #47 The checkbox exposed to contributors in a PR to determine whether the PR has a functional impact states: "Impacts functionality?" This uses positive logic to simplify understanding by the user. Currently the `impact:non-functional` label is applied if the checkbox is checked. This change inverts the logic to apply the label as expected. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
1 parent 960f5c0 commit 729de2b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.sync/workflows/config/label-issues/regex-pull-requests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ impact:breaking-change:
1212
- '\s*-\s*\[\s*[x|X]\s*\] Breaking change\?'
1313

1414
impact:non-functional:
15-
- '\s*-\s*\[\s*[x|X]\s*\] Impacts functionality\?'
15+
- '\s*-\s*\[\s*(?![x|X])\s*\] Impacts functionality\?'
1616

1717
impact:security:
1818
- '\s*-\s*\[\s*[x|X]\s*\] Impacts security\?'

0 commit comments

Comments
 (0)