Skip to content

Commit 4b2e0bd

Browse files
Merge pull request #764 from microsoft/psl-bug-30854
fix: Fix team plan rendering to resolve bug #30854.
2 parents 755455b + b6bc747 commit 4b2e0bd

File tree

6 files changed

+15
-3
lines changed

6 files changed

+15
-3
lines changed

src/frontend/src/components/content/PlanPanelLeft.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ const PlanPanelLeft: React.FC<PlanPanelLefProps> = ({
3636
onTeamUpload,
3737
isHomePage,
3838
selectedTeam: parentSelectedTeam,
39-
onNavigationWithAlert
39+
onNavigationWithAlert,
40+
isLoadingTeam
4041
}) => {
4142
const { dispatchToast } = useToastController("toast");
4243
const navigate = useNavigate();
@@ -218,7 +219,7 @@ const PlanPanelLeft: React.FC<PlanPanelLefProps> = ({
218219

219220
{!isHomePage && (
220221
<TeamSelected
221-
selectedTeam={TeamService.getStoredTeam()}
222+
selectedTeam={selectedTeam}
222223
/>
223224
)}
224225

@@ -247,6 +248,7 @@ const PlanPanelLeft: React.FC<PlanPanelLefProps> = ({
247248
onTaskSelect={handleTaskSelect}
248249
loading={plansLoading}
249250
selectedTaskId={selectedTaskId ?? undefined}
251+
isLoadingTeam={isLoadingTeam}
250252
/>
251253

252254
<PanelFooter>

src/frontend/src/components/content/TaskList.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const TaskList: React.FC<TaskListProps> = ({
2222
onTaskSelect,
2323
loading,
2424
selectedTaskId,
25+
isLoadingTeam
2526
}) => {
2627
const renderTaskItem = (task: Task) => {
2728
const isActive = task.id === selectedTaskId;
@@ -84,7 +85,7 @@ const TaskList: React.FC<TaskListProps> = ({
8485
Completed
8586
</AccordionHeader>
8687
<AccordionPanel>
87-
{loading
88+
{(loading || isLoadingTeam)
8889
? Array.from({ length: 5 }, (_, i) =>
8990
renderSkeleton(`completed-${i}`)
9091
)

src/frontend/src/models/planPanelLeft.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,5 @@ export interface PlanPanelLefProps {
99
isHomePage: boolean;
1010
selectedTeam?: TeamConfig | null;
1111
onNavigationWithAlert?: (navigationFn: () => void) => void;
12+
isLoadingTeam?: boolean;
1213
}

src/frontend/src/models/taskList.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,5 @@ export interface TaskListProps {
1010
onTaskSelect: (taskId: string) => void;
1111
loading?: boolean;
1212
selectedTaskId?: string;
13+
isLoadingTeam?: boolean;
1314
}

src/frontend/src/pages/HomePage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,7 @@ const HomePage: React.FC = () => {
200200
onTeamUpload={handleTeamUpload}
201201
isHomePage={true}
202202
selectedTeam={selectedTeam}
203+
isLoadingTeam={isLoadingTeam}
203204
/>
204205
<Content>
205206
<ContentToolbar

src/frontend/src/pages/PlanPage.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -715,6 +715,12 @@ const PlanPage: React.FC = () => {
715715
initializePlanLoading();
716716
}, [planId, loadPlanData, resetPlanVariables, setErrorLoading]);
717717

718+
useEffect(() => {
719+
if (planData?.team) {
720+
setSelectedTeam(planData.team);
721+
}
722+
}, [planData, setSelectedTeam]);
723+
718724
if (errorLoading) {
719725
return (
720726
<CoralShellColumn>

0 commit comments

Comments
 (0)