Skip to content

Commit 313a9cf

Browse files
Merge pull request #913 from microsoft/psl-pk-pipelinefix
refactor: Refactor JSON error handling and remove allowedFqdnList
2 parents 89d5a19 + 054ad3a commit 313a9cf

File tree

2 files changed

+3
-20
lines changed

2 files changed

+3
-20
lines changed

infra/main.waf.parameters.json

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -91,25 +91,6 @@
9191
},
9292
"MCPContainerRegistryHostname": {
9393
"value": "${AZURE_ENV_CONTAINER_REGISTRY_ENDPOINT}"
94-
},
95-
"allowedFqdnList": {
96-
"value": [
97-
"mcr.microsoft.com",
98-
"openai.azure.com",
99-
"cognitiveservices.azure.com",
100-
"login.microsoftonline.com",
101-
"management.azure.com",
102-
"aiinfra.azure.com",
103-
"aiinfra.azure.net",
104-
"aiinfra.azureedge.net",
105-
"blob.core.windows.net",
106-
"database.windows.net",
107-
"vault.azure.net",
108-
"monitoring.azure.com",
109-
"dc.services.visualstudio.com",
110-
"azconfig.io",
111-
"azconfig.azure.net"
112-
]
11394
}
11495
}
11596
}

infra/scripts/validate_bicep_params.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,9 @@ def parse_parameters_env_vars(json_path: Path) -> dict[str, list[str]]:
108108
data = json.loads(sanitized)
109109
params = data.get("parameters", {})
110110
except json.JSONDecodeError:
111-
pass
111+
# Malformed JSON cannot be reliably parsed for env-var extraction;
112+
# return an empty mapping so the caller can still proceed.
113+
return {}
112114

113115
# Walk each top-level parameter and scan its entire serialized value
114116
# for ${VAR} references from the original text.

0 commit comments

Comments
 (0)