fix: invoice number generation and PDF styling

Invoice Number:
- Make invoice_number optional in createInvoiceSchema
- Backend now generates invoice number if not provided
- Properly trims and checks for empty strings
- Removes frontend invoice number generation to avoid race conditions

PDF Styling:
- Update invoice number color to indigo (#6366F1) for consistency

Author: lauragift21

apps/api/src/routes/invoices.ts

@@ -182,8 +182,8 @@ invoices.post('/', async (c) => {
   const invoiceId = generateUUID();
   const now = new Date().toISOString();
 
-  // Generate invoice number if not provided
-  let invoiceNumber = data.invoice_number;
+  // Generate invoice number if not provided or empty
+  let invoiceNumber = data.invoice_number?.trim();
   if (!invoiceNumber && settings) {
     invoiceNumber = generateInvoiceNumber(settings.invoice_prefix, settings.next_invoice_number);
     // Update next invoice number

apps/api/src/services/pdf.ts

@@ -90,7 +90,7 @@ export class PDFService {
     .invoice-number {
       font-size: 28px;
       font-weight: 700;
-      color: #2563eb;
+      color: #6366F1;
       margin-bottom: 8px;
     }
     

apps/web/src/pages/invoices/form.tsx

@@ -119,9 +119,8 @@ export function InvoiceFormPage() {
       dueDate.setDate(dueDate.getDate() + days);
       setValue('due_date', dueDate.toISOString().split('T')[0]);
 
-      // Generate invoice number
-      const invoiceNumber = `${settings.invoice_prefix}-${settings.next_invoice_number.toString().padStart(5, '0')}`;
-      setValue('invoice_number', invoiceNumber);
+      // Don't set invoice_number for new invoices - let the backend generate it
+      // This ensures proper incrementing even with concurrent invoice creation
     }
   }, [settings, isEditing, setValue]);
 

docs/screenshots/invoice-detail.png

@@ -116,7 +116,7 @@ export const invoiceSchema = z.object({
 
 export const createInvoiceSchema = z.object({
   client_id: z.string().uuid('Invalid client ID'),
-  invoice_number: z.string().min(1, 'Invoice number is required').max(50),
+  invoice_number: z.string().max(50).optional(), // Optional - backend generates if not provided
   issue_date: z.string(),
   due_date: z.string(),
   currency: currencySchema,