Update build-comparison.yml

Author: tomerBZ

.github/workflows/build-comparison.yml

@@ -43,7 +43,6 @@ jobs:
 
       - name: Get latest Ubuntu AMI
         run: |
-          # Get the latest Ubuntu 22.04 AMI ID
           UBUNTU_AMI=$(aws ec2 describe-images \
             --owners 099720109477 \
             --filters \
@@ -126,7 +125,6 @@ jobs:
 
       - name: Get latest Ubuntu AMI
         run: |
-          # Get the latest Ubuntu 22.04 AMI ID  
           UBUNTU_AMI=$(aws ec2 describe-images \
             --owners 099720109477 \
             --filters \
@@ -142,7 +140,6 @@ jobs:
         run: |
           echo "🚀 Starting EC2 Image Builder with AMI: $UBUNTU_AMI"
           
-          # Create component
           cat > component.yml << 'EOF'
           name: InstallNginx
           description: Install Nginx web server
@@ -173,7 +170,6 @@ jobs:
           
           echo "✅ Component created: $COMPONENT_ARN"
           
-          # Create image recipe with the correct AMI ID
           RECIPE_ARN=$(aws imagebuilder create-image-recipe \
             --name "nginx-recipe-$(date +%s)" \
             --semantic-version "1.0.0" \
@@ -185,7 +181,6 @@ jobs:
           
           echo "✅ Recipe created: $RECIPE_ARN"
           
-          # Create infrastructure config
           INFRA_ARN=$(aws imagebuilder create-infrastructure-configuration \
             --name "basic-infra-$(date +%s)" \
             --instance-types t3.micro \
@@ -194,7 +189,6 @@ jobs:
           
           echo "✅ Infrastructure config created: $INFRA_ARN"
           
-          # Start build
           IMAGE_ARN=$(aws imagebuilder create-image \
             --image-recipe-arn "$RECIPE_ARN" \
             --infrastructure-configuration-arn "$INFRA_ARN" \
@@ -205,263 +199,6 @@ jobs:
           echo "Build Summary:" > ec2-imagebuilder-build.log
           echo "Base AMI: $UBUNTU_AMI" >> ec2-imagebuilder-build.log
           echo "Image ARN: $IMAGE_ARN" >> ec2-imagebuilder-build.log
-          echo "Recipe ARN: $RECIPE_ARN" >> ec2-imagebuilder-build.log
-          echo "Component ARN: $COMPONENT_ARN" >> ec2-imagebuilder-build.log
-
-      - name: Upload EC2 Image Builder logs
-        uses: actions/upload-artifact@v4
-        with:
-          name: ec2-imagebuilder-logs
-          path: ec2-imagebuilder-build.log
-
-  comparison-summary:
-    name: Build Comparison Summary
-    runs-on: ubuntu-latest
-    needs: [packer-build, ec2-imagebuilder-build]
-    if: always()
-    
-    steps:
-      - name: Generate comparison report
-        run: |
-          echo "# Image Builder Comparison Report" > comparison-report.md
-          echo "" >> comparison-report.md
-          echo "## Build Results" >> comparison-report.md
-          echo "" >> comparison-report.md
-          
-          if [ "${{ needs.packer-build.result }}" = "success" ]; then
-            echo "✅ **HashiCorp Packer**: Build completed successfully" >> comparison-report.md
-          else
-            echo "❌ **HashiCorp Packer**: Build failed or skipped" >> comparison-report.md
-          fi
-          
-          if [ "${{ needs.ec2-imagebuilder-build.result }}" = "success" ]; then
-            echo "✅ **AWS EC2 Image Builder**: Build completed successfully" >> comparison-report.md
-          else
-            echo "❌ **AWS EC2 Image Builder**: Build failed or skipped" >> comparison-report.md
-          fi
-          
-          echo "" >> comparison-report.md
-          echo "## Key Differences Observed" >> comparison-report.md
-          echo "- **Packer**: Uses direct AMI ID, faster execution" >> comparison-report.md
-          echo "- **EC2 Image Builder**: More verbose setup, better AWS integration" >> comparison-report.md
-          echo "" >> comparison-report.md
-          echo "Build completed at: $(date)" >> comparison-report.md
-          
-          cat comparison-report.md
-
-      - name: Upload comparison report
-        uses: actions/upload-artifact@v4
-        with:
-          name: comparison-report
-          path: comparison-report.mdname: Image Builders Comparison
-
-on:
-  workflow_dispatch:
-    inputs:
-      run_packer:
-        description: 'Run Packer build'
-        type: boolean
-        default: true
-      run_ec2_imagebuilder:
-        description: 'Run EC2 Image Builder'
-        type: boolean
-        default: true
-
-env:
-  AWS_REGION: us-west-2
-
-permissions:
-  id-token: write
-  contents: read
-
-jobs:
-  packer-build:
-    name: HashiCorp Packer Build
-    runs-on: ubuntu-latest
-    if: ${{ github.event.inputs.run_packer == 'true' }}
-    
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Configure AWS credentials
-        uses: aws-actions/configure-aws-credentials@v4
-        with:
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ${{ env.AWS_REGION }}
-
-      - name: Setup Packer
-        uses: hashicorp/setup-packer@main
-        with:
-          version: "1.9.4"
-
-      - name: Get latest Ubuntu AMI
-        run: |
-          # Get the latest Ubuntu 22.04 AMI ID
-          UBUNTU_AMI=$(aws ec2 describe-images \
-            --owners 099720109477 \
-            --filters \
-              "Name=name,Values=ubuntu/images/hvm-ssd/ubuntu-22.04-amd64-server-*" \
-              "Name=state,Values=available" \
-            --query 'Images | sort_by(@, &CreationDate) | [-1].ImageId' \
-            --output text)
-          
-          echo "Found Ubuntu AMI: $UBUNTU_AMI"
-          echo "UBUNTU_AMI=$UBUNTU_AMI" >> $GITHUB_ENV
-
-      - name: Create Packer template
-        run: |
-          cat > packer-template.pkr.hcl << EOF
-          packer {
-            required_plugins {
-              amazon = {
-                source  = "github.com/hashicorp/amazon"
-                version = "~> 1"
-              }
-            }
-          }
-
-          source "amazon-ebs" "ubuntu" {
-            ami_name      = "packer-demo-\${timestamp()}"
-            instance_type = "t3.micro"
-            region        = "${{ env.AWS_REGION }}"
-            source_ami    = "${{ env.UBUNTU_AMI }}"
-            ssh_username  = "ubuntu"
-            
-            tags = {
-              Name = "packer-demo-\${timestamp()}"
-              Tool = "HashiCorp-Packer"
-            }
-          }
-
-          build {
-            sources = ["source.amazon-ebs.ubuntu"]
-            
-            provisioner "shell" {
-              inline = [
-                "sudo apt-get update",
-                "sudo apt-get install -y nginx",
-                "sudo systemctl enable nginx",
-                "echo '<h1>Built with HashiCorp Packer</h1>' | sudo tee /var/www/html/index.html"
-              ]
-            }
-          }
-          EOF
-
-      - name: Initialize and build with Packer
-        run: |
-          echo "🚀 Starting Packer build with AMI: $UBUNTU_AMI"
-          packer init packer-template.pkr.hcl
-          packer validate packer-template.pkr.hcl
-          packer build packer-template.pkr.hcl | tee packer-build.log
-          echo "✅ Packer build completed!"
-
-      - name: Upload Packer logs
-        uses: actions/upload-artifact@v4
-        with:
-          name: packer-build-logs
-          path: packer-build.log
-
-  ec2-imagebuilder-build:
-    name: AWS EC2 Image Builder Build
-    runs-on: ubuntu-latest
-    if: ${{ github.event.inputs.run_ec2_imagebuilder == 'true' }}
-    
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Configure AWS credentials
-        uses: aws-actions/configure-aws-credentials@v4
-        with:
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-          aws-region: ${{ env.AWS_REGION }}
-
-      - name: Get latest Ubuntu AMI
-        run: |
-          # Get the latest Ubuntu 22.04 AMI ID  
-          UBUNTU_AMI=$(aws ec2 describe-images \
-            --owners 099720109477 \
-            --filters \
-              "Name=name,Values=ubuntu/images/hvm-ssd/ubuntu-22.04-amd64-server-*" \
-              "Name=state,Values=available" \
-            --query 'Images | sort_by(@, &CreationDate) | [-1].ImageId' \
-            --output text)
-          
-          echo "Found Ubuntu AMI: $UBUNTU_AMI"
-          echo "UBUNTU_AMI=$UBUNTU_AMI" >> $GITHUB_ENV
-
-      - name: Run EC2 Image Builder pipeline
-        run: |
-          echo "🚀 Starting EC2 Image Builder with AMI: $UBUNTU_AMI"
-          
-          # Create component
-          cat > component.yml << 'EOF'
-          name: InstallNginx
-          description: Install Nginx web server
-          schemaVersion: 1.0
-          phases:
-            - name: build
-              steps:
-                - name: UpdateOS
-                  action: UpdateOS
-                - name: InstallNginx
-                  action: ExecuteBash
-                  inputs:
-                    commands:
-                      - apt-get update
-                      - apt-get install -y nginx
-                      - systemctl enable nginx
-                      - echo '<h1>Built with EC2 Image Builder</h1>' > /var/www/html/index.html
-          EOF
-
-          COMPONENT_ARN=$(aws imagebuilder create-component \
-            --name "nginx-component-$(date +%s)" \
-            --semantic-version "1.0.0" \
-            --description "Install Nginx" \
-            --platform Linux \
-            --data file://component.yml \
-            --query 'componentBuildVersionArn' \
-            --output text)
-          
-          echo "✅ Component created: $COMPONENT_ARN"
-          
-          # Create image recipe with the correct AMI ID
-          RECIPE_ARN=$(aws imagebuilder create-image-recipe \
-            --name "nginx-recipe-$(date +%s)" \
-            --semantic-version "1.0.0" \
-            --description "Ubuntu with Nginx" \
-            --parent-image "$UBUNTU_AMI" \
-            --components componentArn=$COMPONENT_ARN \
-            --query 'imageRecipeArn' \
-            --output text)
-          
-          echo "✅ Recipe created: $RECIPE_ARN"
-          
-          # Create infrastructure config
-          INFRA_ARN=$(aws imagebuilder create-infrastructure-configuration \
-            --name "basic-infra-$(date +%s)" \
-            --instance-types t3.micro \
-            --query 'infrastructureConfigurationArn' \
-            --output text)
-          
-          echo "✅ Infrastructure config created: $INFRA_ARN"
-          
-          # Start build
-          IMAGE_ARN=$(aws imagebuilder create-image \
-            --image-recipe-arn "$RECIPE_ARN" \
-            --infrastructure-configuration-arn "$INFRA_ARN" \
-            --query 'imageBuildVersionArn' \
-            --output text)
-          
-          echo "✅ Image build started: $IMAGE_ARN"
-          echo "Build Summary:" > ec2-imagebuilder-build.log
-          echo "Base AMI: $UBUNTU_AMI" >> ec2-imagebuilder-build.log
-          echo "Image ARN: $IMAGE_ARN" >> ec2-imagebuilder-build.log
-          echo "Recipe ARN: $RECIPE_ARN" >> ec2-imagebuilder-build.log
-          echo "Component ARN: $COMPONENT_ARN" >> ec2-imagebuilder-build.log
 
       - name: Upload EC2 Image Builder logs
         uses: actions/upload-artifact@v4