Skip to content

Commit cbadd29

Browse files
oharboeclaude
andcommitted
Restore GDS dependency on finish target
No changes to the non do- versions of targets. bazel-orfs does not use the finish target; it uses do-finish and can invoke do-gds as a separate step. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
1 parent 6a140bf commit cbadd29

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

flow/Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,8 @@ klayout_guides: $(RESULTS_DIR)/5_route.def $(OBJECTS_DIR)/klayout.lyt
598598
.PHONY: finish
599599
finish: $(LOG_DIR)/6_report.log \
600600
$(RESULTS_DIR)/6_final.v \
601-
$(RESULTS_DIR)/6_final.sdc
601+
$(RESULTS_DIR)/6_final.sdc \
602+
$(GDS_FINAL_FILE)
602603
$(UNSET_AND_MAKE) elapsed
603604

604605
.PHONY: elapsed
@@ -650,7 +651,7 @@ clean_abstract:
650651
check-klayout:
651652
@if [ -z "$(KLAYOUT_CMD)" ]; then \
652653
echo "Error: KLayout not found. Install KLayout or set KLAYOUT_CMD."; \
653-
echo "Hint: 'make finish' works without KLayout. Only GDS/DRC/LVS need it."; \
654+
echo "Hint: KLayout is needed for GDS/DRC/LVS targets."; \
654655
exit 1; \
655656
fi
656657

flow/docs/KLayoutOptionalDependency.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ without KLayout installed.
99

1010
| Target | Requires KLayout | Description |
1111
|---|---|---|
12-
| `make finish` | No | Complete flow through timing reports |
12+
| `make finish` | Yes | Complete flow including GDS generation |
1313
| `make gds` | Yes | Generate GDS/OAS from finished design |
1414
| `make drc` | Yes | Run DRC checks (requires GDS) |
1515
| `make lvs` | Yes | Run LVS checks (requires GDS) |
@@ -22,7 +22,7 @@ missing and a KLayout-dependent target is invoked:
2222

2323
```
2424
Error: KLayout not found. Install KLayout or set KLAYOUT_CMD.
25-
Hint: 'make finish' works without KLayout. Only GDS/DRC/LVS need it.
25+
Hint: KLayout is needed for GDS/DRC/LVS targets.
2626
```
2727

2828
## bazel-orfs Integration

0 commit comments

Comments
 (0)