Skip to content

Commit 2565e81

Browse files
authored
Merge pull request #4057 from ashnaaseth2325-oss/fix/genmetrics-fd-leak
fix: prevent file descriptor leak in is_git_repo() by using context manager
2 parents 1ad9ee5 + 365725a commit 2565e81

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

flow/util/genMetrics.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,10 +175,11 @@ def read_sdc(file_name):
175175

176176
def is_git_repo(folder=None):
177177
cmd = ["git", "branch"]
178-
if folder is not None:
179-
return call(cmd, stderr=STDOUT, stdout=open(os.devnull, "w"), cwd=folder) == 0
180-
else:
181-
return call(cmd, stderr=STDOUT, stdout=open(os.devnull, "w")) == 0
178+
with open(os.devnull, "w") as devnull:
179+
if folder is not None:
180+
return call(cmd, stderr=STDOUT, stdout=devnull, cwd=folder) == 0
181+
else:
182+
return call(cmd, stderr=STDOUT, stdout=devnull) == 0
182183

183184

184185
def merge_jsons(root_path, output, files):

0 commit comments

Comments
 (0)