Skip to content

Commit 2c189be

Browse files
SONARJAVA-5017 S4684 Add support for Jakarta (#5495)
1 parent ac55c05 commit 2c189be

File tree

4 files changed

+29
-2
lines changed

4 files changed

+29
-2
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"ruleKey": "S4684",
33
"hasTruePositives": false,
4-
"falseNegatives": 9,
4+
"falseNegatives": 11,
55
"falsePositives": 0
66
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"ruleKey": "S6856",
33
"hasTruePositives": false,
4-
"falseNegatives": 46,
4+
"falseNegatives": 47,
55
"falsePositives": 0
66
}

java-checks-test-sources/default/src/main/java/checks/spring/PersistentEntityUsedAsRequestParameterCheckSample.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,20 @@ public class Bar {
4848
public class Baz {
4949
}
5050

51+
@jakarta.persistence.Entity
52+
public class JakartaFoo {
53+
private Long id;
54+
55+
public void setId(Long id) {
56+
this.id = id;
57+
}
58+
59+
@jakarta.persistence.Id
60+
public Long getId() {
61+
return id;
62+
}
63+
}
64+
5165
@Controller
5266
class FooController {
5367

@@ -107,6 +121,18 @@ public void foo7(
107121
Doc doc) { // Noncompliant
108122
}
109123

124+
@PostMapping
125+
public void jakartaFoo1(JakartaFoo jakartaFoo) { // Noncompliant
126+
}
127+
128+
@GetMapping
129+
public void jakartaFoo2(JakartaFoo jakartaFoo) { // Noncompliant
130+
}
131+
132+
@PostMapping
133+
public void jakartaFoo3(@PathVariable("id") final JakartaFoo jakartaFoo) { // Compliant
134+
}
135+
110136
@PostMapping
111137
public Foo ok1(String s) {
112138
Foo foo = new Foo();

java-checks/src/main/java/org/sonar/java/checks/spring/PersistentEntityUsedAsRequestParameterCheck.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public List<Tree.Kind> nodesToVisit() {
4949

5050
private static final List<String> ENTITY_ANNOTATIONS = List.of(
5151
"javax.persistence.Entity",
52+
"jakarta.persistence.Entity",
5253
"org.springframework.data.mongodb.core.mapping.Document",
5354
"org.springframework.data.elasticsearch.annotations.Document"
5455
);

0 commit comments

Comments
 (0)