Skip to content

Commit c98ad80

Browse files
committed
Fix Util.getSignatureData javadoc
1 parent 523786b commit c98ad80

File tree

1 file changed

+13
-21
lines changed
  • core/src/main/java/com/onelogin/saml2/util

1 file changed

+13
-21
lines changed

core/src/main/java/com/onelogin/saml2/util/Util.java

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ public static boolean validateSign(final Document doc, final List<X509Certificat
989989
return false;
990990
}
991991

992-
/**
992+
/**
993993
* Validate signature (Metadata).
994994
*
995995
* @param doc
@@ -1007,7 +1007,7 @@ public static Boolean validateMetadataSign(Document doc, X509Certificate cert, S
10071007
return validateMetadataSign(doc, cert, fingerprint, alg, false);
10081008
}
10091009

1010-
/**
1010+
/**
10111011
* Validate signature (Metadata).
10121012
*
10131013
* @param doc
@@ -1051,39 +1051,31 @@ public static Boolean validateMetadataSign(Document doc, X509Certificate cert, S
10511051
return false;
10521052
}
10531053

1054-
/**
1055-
* Validate signature (Metadata).
1054+
/**
1055+
* Extract signature data from a DOM {@link Node}.
10561056
*
1057-
* @param doc
1058-
* The document we should validate
1059-
* @param cert
1060-
* The public certificate
1061-
* @param fingerprint
1062-
* The fingerprint of the public certificate
1057+
* @param signNode
1058+
* The signed node
10631059
* @param alg
10641060
* The signature algorithm method
10651061
*
1066-
* @return True if the sign is valid, false otherwise.
1062+
* @return a Map containing the signature data (actual signature, certificate, fingerprint)
10671063
*/
10681064
private static Map<String,Object> getSignatureData(Node signNode, String alg) {
10691065
return getSignatureData(signNode, alg, false);
10701066
}
10711067

1072-
/**
1073-
* Validate signature (Metadata).
1068+
/**
1069+
* Extract signature data from a DOM {@link Node}.
10741070
*
1075-
* @param doc
1076-
* The document we should validate
1077-
* @param cert
1078-
* The public certificate
1079-
* @param fingerprint
1080-
* The fingerprint of the public certificate
1071+
* @param signNode
1072+
* The signed node
10811073
* @param alg
10821074
* The signature algorithm method
10831075
* @param rejectDeprecatedAlg
1084-
* Flag to invalidate or not Signatures with deprecated alg
1076+
* Whether to ignore signature if a deprecated algorithm is used
10851077
*
1086-
* @return True if the sign is valid, false otherwise.
1078+
* @return a Map containing the signature data (actual signature, certificate, fingerprint)
10871079
*/
10881080
private static Map<String,Object> getSignatureData(Node signNode, String alg, Boolean rejectDeprecatedAlg) {
10891081
Map<String,Object> signatureData = new HashMap<>();

0 commit comments

Comments
 (0)