Skip to content

Commit 6496252

Browse files
author
Tal Hadad
committed
fix the host passing on .vsc.attach
1 parent 099ccea commit 6496252

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/rTerminal.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22

33
import * as path from 'path';
4+
import * as os from 'os';
45
import { isDeepStrictEqual } from 'util';
56

67
import * as vscode from 'vscode';
@@ -130,7 +131,7 @@ export async function makeTerminalOptions(): Promise<vscode.TerminalOptions> {
130131
R_PROFILE_USER: newRprofile,
131132
VSCODE_INIT_R: initR,
132133
VSCODE_WATCHER_DIR: homeExtDir(),
133-
VSCODE_ATTACH_HOST: incomingRequestServerAddressInfo?.address,
134+
VSCODE_ATTACH_HOST: os.hostname(),
134135
VSCODE_ATTACH_PORT: incomingRequestServerAddressInfo?.port?.toString(),
135136
};
136137
}

src/session.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ export function attachActive(): void {
131131
if (config().get<boolean>('sessionWatcher')) {
132132
console.info('[attachActive]');
133133
if (incomingRequestServerAddressInfo) {
134-
void runTextInTerm(`.vsc.attach(host=${incomingRequestServerAddressInfo.address}, port=${incomingRequestServerAddressInfo.port}L)`);
134+
void runTextInTerm(`.vsc.attach(host=${JSON.stringify(os.hostname())}, port=${incomingRequestServerAddressInfo.port}L)`);
135135
} else {
136136
void runTextInTerm('.vsc.attach()');
137137
}

0 commit comments

Comments
 (0)