Address detekt changes

- Baseline 2 new UseCheckOrError entries for OneSignalImp.kt for updateUserJwt/updateUserJwtSuspend init guards that follow the existing login/logout pattern.
- Baseline ReturnCount for hasValidJwtIfRequired — the guard-clause style is clearer than collapsing into a single boolean expression for this JWT gating logic.
- Narrow JwtTokenStore catch from Exception to JSONException to satisfy detekt's TooGenericExceptionCaught rule, no baseline added.

Author: nan-li

OneSignalSDK/detekt/detekt-baseline-core.xml

@@ -279,6 +279,7 @@
     <ID>PrintStackTrace:TrackGooglePurchase.kt$TrackGooglePurchase$e</ID>
     <ID>PrintStackTrace:TrackGooglePurchase.kt$TrackGooglePurchase.&lt;no name provided>$t</ID>
     <ID>RethrowCaughtException:OSDatabase.kt$OSDatabase$throw e</ID>
+    <ID>ReturnCount:OperationRepo.kt$OperationRepo$private fun hasValidJwtIfRequired( identityVerificationEnabled: Boolean, op: Operation, ): Boolean</ID>
     <ID>ReturnCount:AppIdResolution.kt$fun resolveAppId( inputAppId: String?, configModel: ConfigModel, preferencesService: IPreferencesService, ): AppIdResolution</ID>
     <ID>ReturnCount:BackgroundManager.kt$BackgroundManager$override fun cancelRunBackgroundServices(): Boolean</ID>
     <ID>ReturnCount:OneSignalImp.kt$OneSignalImp$private fun internalInit( context: Context, appId: String?, ): Boolean</ID>
@@ -609,6 +610,8 @@
     <ID>UnusedPrivateMember:OperationRepo.kt$OperationRepo$private val _time: ITime</ID>
     <ID>UseCheckOrError:OneSignalImp.kt$OneSignalImp$throw IllegalStateException("'initWithContext failed' before 'login'")</ID>
     <ID>UseCheckOrError:OneSignalImp.kt$OneSignalImp$throw IllegalStateException("'initWithContext failed' before 'logout'")</ID>
+    <ID>UseCheckOrError:OneSignalImp.kt$OneSignalImp$throw IllegalStateException("'initWithContext failed' before 'updateUserJwt'")</ID>
+    <ID>UseCheckOrError:OneSignalImp.kt$OneSignalImp$throw IllegalStateException("Must call 'initWithContext' before 'updateUserJwt'")</ID>
     <ID>UseCheckOrError:OneSignalImp.kt$OneSignalImp$throw initFailureException ?: IllegalStateException("Initialization failed. Cannot proceed.")</ID>
   </CurrentIssues>
 </SmellBaseline>

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/operations/impl/OperationRepo.kt

@@ -431,11 +431,10 @@ internal class OperationRepo(
      * also held because they cannot be authenticated.
      */
     private fun hasValidJwtIfRequired(
-        iv: Boolean,
+        identityVerificationEnabled: Boolean,
         op: Operation,
     ): Boolean {
-        if (!iv) return true
-        if (!op.requiresJwt) return true
+        if (!identityVerificationEnabled || !op.requiresJwt) return true
         val externalId = op.externalId ?: return false
         return _jwtTokenStore.getJwt(externalId) != null
     }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/identity/JwtTokenStore.kt

@@ -4,6 +4,7 @@ import com.onesignal.core.internal.preferences.IPreferencesService
 import com.onesignal.core.internal.preferences.PreferenceOneSignalKeys
 import com.onesignal.core.internal.preferences.PreferenceStores
 import com.onesignal.debug.internal.logging.Logging
+import org.json.JSONException
 import org.json.JSONObject
 
 /**
@@ -34,7 +35,7 @@ class JwtTokenStore(
                 for (key in obj.keys()) {
                     tokens[key] = obj.getString(key)
                 }
-            } catch (e: Exception) {
+            } catch (e: JSONException) {
                 Logging.warn("JwtTokenStore: failed to parse persisted tokens, starting fresh", e)
             }
         }