the last fix makes all these test passing

rbri · rbri · commit 8de9b6632a93 · 2024-03-09T19:03:03.000+01:00
diff --git a/src/test/java/org/htmlunit/html/HtmlElement2Test.java b/src/test/java/org/htmlunit/html/HtmlElement2Test.java
@@ -298,9 +298,6 @@ public void removeParentOfActiveElement() throws Exception {
      */
     @Test
     @Alerts({"before appendChild;after appendChild;image onload;after removeChild;", "2"})
-    // HtmlUnit loads images synchron - because of this the removeChild is called before the
-    // node is appended and fails
-    @NotYetImplemented
     public void addRemove() throws Exception {
         try (InputStream is = getClass().getClassLoader().getResourceAsStream("testfiles/tiny-jpg.img")) {
             final byte[] directBytes = IOUtils.toByteArray(is);
diff --git a/src/test/java/org/htmlunit/javascript/host/dom/DOMImplementationTest.java b/src/test/java/org/htmlunit/javascript/host/dom/DOMImplementationTest.java
@@ -18,7 +18,6 @@
 import org.htmlunit.html.HtmlPageTest;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.BrowserRunner.Alerts;
-import org.htmlunit.junit.BrowserRunner.NotYetImplemented;
 import org.htmlunit.util.MimeType;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -623,7 +622,6 @@ public void createHTMLDocumentInnerAddImg() throws Exception {
      */
     @Test
     @Alerts("before1")
-    @NotYetImplemented
     public void createHTMLDocumentInnerAddImgAddDocToIframe() throws Exception {
         final String html = HtmlPageTest.STANDARDS_MODE_PREFIX_
                 + "<html>\n"
@@ -641,7 +639,6 @@ public void createHTMLDocumentInnerAddImgAddDocToIframe() throws Exception {
                 + "      var srcNode = doc.documentElement;\n"
                 + "      var newNode = destDocument.importNode(srcNode, true);\n"
                 + "      destDocument.replaceChild(newNode, destDocument.documentElement);\n"
-                // + "      alert('before');\n"
                 + "      window.parent.document.title += 'before';"
 
                 + "    } catch(e) { window.parent.document.title += 'exception'; }\n"
diff --git a/src/test/java/org/htmlunit/javascript/host/html/HTMLImageElementTest.java b/src/test/java/org/htmlunit/javascript/host/html/HTMLImageElementTest.java
@@ -1489,22 +1489,6 @@ public void onLoad_orderNotAttached() throws Exception {
         "mousedown", "in", "out",
         "mouseup", "in", "out",
         "click", "in", "out", "Image.onload(1)", "Image.onload(2)", "Image.onload(3)"})
-    @HtmlUnitNYI(CHROME = {"in", "Image.onload(0)", "out",
-        "mousedown", "in", "Image.onload(1)", "out",
-        "mouseup", "in", "Image.onload(2)", "out",
-        "click", "in", "Image.onload(3)", "out"},
-        EDGE = {"in", "Image.onload(0)", "out",
-                "mousedown", "in", "Image.onload(1)", "out",
-                "mouseup", "in", "Image.onload(2)", "out",
-                "click", "in", "Image.onload(3)", "out"},
-        FF = {"in", "Image.onload(0)", "out",
-              "mousedown", "in", "Image.onload(1)", "out",
-              "mouseup", "in", "Image.onload(2)", "out",
-              "click", "in", "Image.onload(3)", "out"},
-        FF_ESR = {"in", "Image.onload(0)", "out",
-                  "mousedown", "in", "Image.onload(1)", "out",
-                  "mouseup", "in", "Image.onload(2)", "out",
-                  "click", "in", "Image.onload(3)", "out"})
     public void onload_complex() throws Exception {
         try (InputStream is = getClass().getClassLoader().getResourceAsStream("testfiles/tiny-jpg.img")) {
             final byte[] directBytes = IOUtils.toByteArray(is);
