Skip to content

Commit f772e79

Browse files
szuenddevtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com
authored andcommitted
Add @ts-ignore to Image.js as TS6 forbids untyped side-effect imports
R=kimanh@chromium.org Bug: 503111303,502804868 Change-Id: Ib472dfb87341cac90f4cbec9dc97aa6cc5ceb28b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7767789 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
1 parent 33679f8 commit f772e79

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

front_end/entrypoints/device_mode_emulation_frame/device_mode_emulation_frame.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
// found in the LICENSE file.
44

55
import '../../core/dom_extension/dom_extension.js';
6+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
7+
// @ts-ignore: tsc 6.0 does not support side-effect imports without a type definition.
8+
// We cannot use `@ts-expect-error` here because the import is correctly resolved
9+
// when bundling the application (which doesn't error) and only errors in unbundled builds.
610
import '../../Images/Images.js';
711

812
if (window.opener) {

front_end/entrypoints/shell/shell.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
6+
// @ts-ignore: tsc 6.0 does not support side-effect imports without a type definition.
7+
// We cannot use `@ts-expect-error` here because the import is correctly resolved
8+
// when bundling the application (which doesn't error) and only errors in unbundled builds.
59
import '../../Images/Images.js';
610
import '../../core/dom_extension/dom_extension.js';
711
import '../../panels/sources/sources-meta.js';

front_end/entrypoints/trace_app/trace_app.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ import '../main/main-meta.js';
66
import '../inspector_main/inspector_main-meta.js';
77
import '../../core/sdk/sdk-meta.js';
88
import '../../models/workspace/workspace-meta.js';
9+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
10+
// @ts-ignore: tsc 6.0 does not support side-effect imports without a type definition.
11+
// We cannot use `@ts-expect-error` here because the import is correctly resolved
12+
// when bundling the application (which doesn't error) and only errors in unbundled builds.
913
import '../../Images/Images.js';
1014
import '../../models/logs/logs-meta.js';
1115
import '../../models/persistence/persistence-meta.js';

0 commit comments

Comments
 (0)