[stack_trace]: Augment RawFrames with script IDs

This CL duplicates the existing behavior where we try to match parsed
URLs/line/column numbers to a script ID we received via
Runtime.getExceptionDetails.

This is not 100% bulletproof as URLs are not unique inside a V8
instance, but this has worked well enough in practice that we'll
keep it.

R=pfaffe@chromium.org

Bug: 485142682
Change-Id: Ia0afb5174404594d37b49c90530dad9e279d0ea1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7754109
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>

Author: szuend

front_end/models/stack_trace/DetailedErrorStackParser.test.ts

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import type * as Protocol from '../../generated/protocol.js';
+
 // eslint-disable-next-line @devtools/es-modules-import
 import * as StackTraceImpl from './stack_trace_impl.js';
 
@@ -191,4 +193,40 @@ describe('DetailedErrorStackParser', () => {
       assert.strictEqual(frames[0].functionName, 'Promise.all');
     });
   });
+
+  describe('augmentRawFramesWithScriptIds', () => {
+    it('augments raw frames with script IDs from Protocol.Runtime.StackTrace', () => {
+      const frames: StackTraceImpl.Trie.RawFrame[] = [
+        {
+          url: 'http://www.example.org/script.js',
+          functionName: 'foo',
+          lineNumber: 9,
+          columnNumber: 4,
+        },
+        {
+          url: 'http://www.example.org/other.js',
+          functionName: 'bar',
+          lineNumber: 19,
+          columnNumber: 0,
+        },
+      ];
+
+      const protocolStackTrace: Protocol.Runtime.StackTrace = {
+        callFrames: [
+          {
+            functionName: 'foo',
+            scriptId: '123' as Protocol.Runtime.ScriptId,
+            url: 'http://www.example.org/script.js',
+            lineNumber: 9,
+            columnNumber: 4,
+          },
+        ],
+      };
+
+      StackTraceImpl.DetailedErrorStackParser.augmentRawFramesWithScriptIds(frames, protocolStackTrace);
+
+      assert.strictEqual(frames[0].scriptId, '123');
+      assert.isUndefined(frames[1].scriptId);
+    });
+  });
 });

front_end/models/stack_trace/DetailedErrorStackParser.ts

@@ -4,6 +4,7 @@
 
 import * as Common from '../../core/common/common.js';
 import type * as Platform from '../../core/platform/platform.js';
+import type * as Protocol from '../../generated/protocol.js';
 
 import type {RawFrame} from './Trie.js';
 
@@ -140,3 +141,21 @@ export function parseRawFramesFromErrorStack(stack: string): RawFrame[] {
   }
   return rawFrames;
 }
+
+/**
+ * Error#stack output only contains script URLs. In some cases we are able to
+ * retrieve additional exception details from V8 that we can use to augment
+ * the parsed Error#stack with script IDs.
+ */
+export function augmentRawFramesWithScriptIds(
+    rawFrames: RawFrame[], protocolStackTrace: Protocol.Runtime.StackTrace): void {
+  for (const rawFrame of rawFrames) {
+    const protocolFrame = protocolStackTrace.callFrames.find(
+        frame => rawFrame.url === frame.url && rawFrame.lineNumber === frame.lineNumber &&
+            rawFrame.columnNumber === frame.columnNumber);
+    if (protocolFrame) {
+      // @ts-expect-error scriptId is a readonly property.
+      rawFrame.scriptId = protocolFrame.scriptId;
+    }
+  }
+}