AI: ensure users who enable AI with V2 do not see opt in

This CL fixes a case where:

1. We ship AIv2
2. A user enables AI Assistance for the first time
3. They go to AI Assistance, and see the opt-in dialog.

(3) is not correct; because the user opted in under V2, they do not
need to see the dialog. This CL fixes this by setting the dialog to
"seen" in the event that a user with V2 enables it.

Fixed: 502511336
Change-Id: I9753fa60c1c749f5e10d78ff0c36b6c46053028e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7760115
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>

Author: jackfranklin

front_end/panels/settings/AISettingsTab.test.ts

@@ -320,4 +320,50 @@ describeWithEnvironment('AISettingsTab', () => {
     assert.exists(aiAssistanceParams);
     assert.strictEqual(aiAssistanceParams.settingDescription, 'Get help with understanding CSS styles');
   });
+
+  it('marks the V2 opt-in dialog as seen when turning on AI assistance in V2', async () => {
+    updateHostConfig({
+      devToolsAiAssistanceV2: {
+        enabled: true,
+      },
+    });
+    const aiAssistanceEnabledSetting = Common.Settings.moduleSetting('ai-assistance-enabled');
+    aiAssistanceEnabledSetting.set(false);
+    const v2OptInSeenSetting = Common.Settings.moduleSetting('ai-assistance-v2-opt-in-change-dialog-seen');
+    v2OptInSeenSetting.set(false);
+
+    const {view} = await setupWidget();
+
+    const settingToParams = Array.from(view.input.settingToParams.entries());
+    const aiAssistanceEntry = settingToParams.find(entry => entry[1].settingName === 'AI assistance');
+    assert.exists(aiAssistanceEntry);
+
+    view.input.toggleSetting(aiAssistanceEntry[0], new Switch.Switch.SwitchChangeEvent(true));
+
+    assert.isTrue(aiAssistanceEnabledSetting.get());
+    assert.isTrue(v2OptInSeenSetting.get());
+  });
+
+  it('does not mark the V2 opt-in dialog as seen when turning on AI assistance in V1', async () => {
+    updateHostConfig({
+      devToolsAiAssistanceV2: {
+        enabled: false,
+      },
+    });
+    const aiAssistanceEnabledSetting = Common.Settings.moduleSetting('ai-assistance-enabled');
+    aiAssistanceEnabledSetting.set(false);
+    const v2OptInSeenSetting = Common.Settings.moduleSetting('ai-assistance-v2-opt-in-change-dialog-seen');
+    v2OptInSeenSetting.set(false);
+
+    const {view} = await setupWidget();
+
+    const settingToParams = Array.from(view.input.settingToParams.entries());
+    const aiAssistanceEntry = settingToParams.find(entry => entry[1].settingName === 'AI assistance');
+    assert.exists(aiAssistanceEntry);
+
+    view.input.toggleSetting(aiAssistanceEntry[0], new Switch.Switch.SwitchChangeEvent(true));
+
+    assert.isTrue(aiAssistanceEnabledSetting.get());
+    assert.isFalse(v2OptInSeenSetting.get());
+  });
 });

front_end/panels/settings/AISettingsTab.ts

@@ -684,9 +684,20 @@ export class AISettingsTab extends UI.Widget.VBox {
             .createSetting('console-insights-skip-reminder', true, Common.Settings.SettingStorageType.SESSION)
             .set(true);
       }
-    } else if (setting.name === 'ai-assistance-enabled' && !setting.get()) {
-      // If the "AI Assistance" is toggled off, we remove all the history entries related to the feature.
-      void AiAssistanceModel.AiHistoryStorage.AiHistoryStorage.instance().deleteAll();
+    } else if (setting.name === 'ai-assistance-enabled') {
+      if (!setting.get()) {
+        // If the "AI Assistance" is toggled off, we remove all the history entries related to the feature.
+        void AiAssistanceModel.AiHistoryStorage.AiHistoryStorage.instance().deleteAll();
+      }
+
+      if (Root.Runtime.hostConfig.devToolsAiAssistanceV2?.enabled && setting.get()) {
+        // If the user turns on ai-assistance whilst on the V2 experiment, they
+        // do not need to see the opt-in change management dialog. This dialog
+        // exists to inform users who opted-in to "V1" that in "V2" there are
+        // some data access changes. But if a user opts-in when on "V2", they
+        // do not need to see that dialog.
+        Common.Settings.Settings.instance().moduleSetting('ai-assistance-v2-opt-in-change-dialog-seen').set(true);
+      }
     }
     this.requestUpdate();
   }