Skip to content

Commit 1647a51

Browse files
indutny-signaldevtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com
authored andcommitted
Fix context selector not showing execution contexts
When execution context's origin is `file://` - the `url.domain()` is an empty string and the item's subtitle becomes falsy. Since we predicated rendering of an item on presence of both title and subtitle - the items were not rendered while still taking space in the dropdown. Bug: 502830845 Change-Id: I17bfb26edafbc7471f782c953205fe1a49349943 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7761316 Commit-Queue: Samiya Caur <samiyac@chromium.org> Reviewed-by: Danil Somsikov <dsv@chromium.org> Reviewed-by: Samiya Caur <samiyac@chromium.org>
1 parent ef56a52 commit 1647a51

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Emir D <emrd434@gmail.com>
4141
Ergün Erdoğmuş <erdogmusergun@gmail.com>
4242
Eric Rannaud <eric.rannaud@gmail.com>
4343
Faisal Salman <fyzlman@gmail.com>
44+
Fedor Indutny <indutny@signal.org>
4445
Feng Lu <lufengd3@gmail.com>
4546
Feng Yu <f3n67u@gmail.com>
4647
Gabriel Luong <gabriel.luong@gmail.com>

front_end/panels/console/ConsoleContextSelector.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ interface ViewInput {
303303
type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
304304

305305
const DEFAULT_VIEW: View = (input, _output, target): void => {
306-
if (!input.title || !input.subtitle) {
306+
if (!input.title) {
307307
render(nothing, target);
308308
return;
309309
}

0 commit comments

Comments
 (0)