Skip to content

Commit e140944

Browse files
committed
refractor: new pageRequest method for spring-boot upgrade
1 parent 41993ce commit e140944

File tree

4 files changed

+16
-7
lines changed

4 files changed

+16
-7
lines changed

src/main/java/org/apereo/openlrw/events/service/EventService.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import org.springframework.beans.factory.annotation.Autowired;
1616
import org.springframework.data.domain.PageRequest;
1717
import org.springframework.data.domain.Pageable;
18+
import org.springframework.data.domain.Sort;
1819
import org.springframework.data.mongodb.core.MongoOperations;
1920
import org.springframework.data.mongodb.core.query.Query;
2021
import org.springframework.stereotype.Service;
@@ -127,7 +128,8 @@ public Event getEventForId(final String tenantId, final String orgId, final Stri
127128
* @return Collection<Event>
128129
*/
129130
public Collection<Event> findAll(final String tenantId, final String orgId, String page, String limit) throws Exception {
130-
Pageable pageRequest = new PageRequest(Integer.parseInt(page), Integer.parseInt(limit));
131+
Pageable pageRequest = PageRequest.of(Integer.parseInt(page), Integer.parseInt(limit), Sort.by("eventTime").descending());
132+
131133
try {
132134
Collection<MongoEvent> mongoEvents = mongoEventRepository.findTopByTenantIdAndOrganizationIdOrderByEventEventTimeDesc(tenantId, orgId, pageRequest);
133135

@@ -156,8 +158,9 @@ public Collection<Event> findAll(final String tenantId, final String orgId, Stri
156158
* @throws EventNotFoundException
157159
*/
158160
public Collection<Event> findByEdApp(final String tenantId, final String orgId, final String page, final String limit, final String edAppId) throws EventNotFoundException {
159-
Pageable pageRequest = new PageRequest(Integer.parseInt(page), Integer.parseInt(limit));
160-
Collection<MongoEvent> mongoEvents = mongoEventRepository.findTopByTenantIdAndOrganizationIdAndEventEdAppIdOrderByEventEventTimeDesc(tenantId, orgId, edAppId, pageRequest);
161+
Pageable pageRequest = PageRequest.of(Integer.parseInt(page), Integer.parseInt(limit), Sort.by("eventTime"));
162+
163+
Collection<MongoEvent> mongoEvents = mongoEventRepository.findTopByTenantIdAndOrganizationIdAndEventEdAppIdOrderByEventEventTimeDesc(tenantId, orgId, edAppId, pageRequest);
161164
if (mongoEvents != null && !mongoEvents.isEmpty()) {
162165
return mongoEvents.stream().map(MongoEvent::getEvent).collect(Collectors.toList());
163166
}

src/main/java/org/apereo/openlrw/oneroster/service/EnrollmentService.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import org.springframework.beans.factory.annotation.Autowired;
1111
import org.springframework.data.domain.PageRequest;
1212
import org.springframework.data.domain.Pageable;
13+
import org.springframework.data.domain.Sort;
1314
import org.springframework.data.mongodb.core.MongoOperations;
1415
import org.springframework.data.mongodb.core.query.Query;
1516
import org.springframework.stereotype.Service;
@@ -185,19 +186,22 @@ public boolean deleteAll(final String tenantId, final String orgId) {
185186
* @throws Exception
186187
*/
187188
public List<Enrollment> findAll(final String tenantId, final String orgId, String page, String limit, String orderBy) throws Exception {
188-
Pageable pageRequest = new PageRequest(Integer.parseInt(page), Integer.parseInt(limit));
189+
Pageable pageRequest;
189190
orderBy = StringUtils.lowerCase(orderBy);
190191
List<MongoEnrollment> mongoEnrollments;
191192

192193
try {
193194
switch (orderBy) {
194195
case "begindate":
196+
pageRequest = PageRequest.of(Integer.parseInt(page), Integer.parseInt(limit), Sort.by("beginDate").descending());
195197
mongoEnrollments = mongoEnrollmentRepository.findTopByTenantIdAndOrgIdOrderByEnrollmentBeginDateDesc(tenantId, orgId, pageRequest);
196198
break;
197199
case "enddate":
200+
pageRequest = PageRequest.of(Integer.parseInt(page), Integer.parseInt(limit), Sort.by("endDate").descending());
198201
mongoEnrollments = mongoEnrollmentRepository.findTopByTenantIdAndOrgIdOrderByEnrollmentEndDateDesc(tenantId, orgId, pageRequest);
199202
break;
200203
default:
204+
pageRequest = PageRequest.of(Integer.parseInt(page), Integer.parseInt(limit), Sort.unsorted());
201205
mongoEnrollments = mongoEnrollmentRepository.findTopByTenantIdAndOrgId(tenantId, orgId, pageRequest);
202206
break;
203207
}

src/main/java/org/apereo/openlrw/oneroster/service/ResultService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import org.springframework.beans.factory.annotation.Autowired;
1212
import org.springframework.data.domain.PageRequest;
1313
import org.springframework.data.domain.Pageable;
14+
import org.springframework.data.domain.Sort;
1415
import org.springframework.data.mongodb.core.MongoOperations;
1516
import org.springframework.data.mongodb.core.query.Query;
1617
import org.springframework.stereotype.Service;
@@ -133,7 +134,7 @@ private Result getResult(final String parameter, MongoResult mongoResult) {
133134
*/
134135
public List<Result> findAll(final String tenantId, final String orgId, String page, String limit) throws Exception {
135136
try {
136-
Pageable pageRequest = new PageRequest(Integer.parseInt(page), Integer.parseInt(limit));
137+
PageRequest pageRequest = PageRequest.of(Integer.parseInt(page), Integer.parseInt(limit), Sort.unsorted());
137138
List<MongoResult> mongoResults = mongoResultRepository.findTopByTenantIdAndOrgIdOrderByResultDateDesc(tenantId, orgId, pageRequest);
138139
if (mongoResults != null && !mongoResults.isEmpty()) {
139140
return mongoResults.stream().map(MongoResult::getResult).collect(Collectors.toList());

src/main/java/org/apereo/openlrw/risk/service/RiskService.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ public Collection<MongoRisk> getRisksForClass(final String tenantId, final Strin
127127
Collection<MongoRisk> mongoRisks;
128128

129129
Query query = new Query();
130-
query.with(new Sort(Sort.Direction.DESC, "dateTime")); // Order by date: the most recent
130+
131+
query.with(Sort.by("dateTime").descending()); // Order by date: the most recent
131132
query.addCriteria(where("classSourcedId").is(classId).and("orgId").is(orgId).and("tenantId").is(tenantId));
132133

133134
if (limit > 0)
@@ -163,7 +164,7 @@ public Collection<MongoRisk> getRisksForUserAndClass(
163164
Collection<MongoRisk> mongoRisks;
164165

165166
Query query = new Query();
166-
query.with(new Sort(Sort.Direction.DESC, "dateTime")); // Order by date: the most recent
167+
query.with(Sort.by("dateTime").descending()); // Order by date: the most recent
167168
query.addCriteria(where("userSourcedId").is(userId).and("classSourcedId").is(classId).and("orgId").is(orgId).and("tenantId").is(tenantId));
168169

169170
if (limit > 0)

0 commit comments

Comments
 (0)